You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 05:54:56 UTC

[GitHub] [arrow] emkornfield commented on pull request #7060: ARROW-8619: [C++] Use distinct enum values for MonthInterval, DayTimeInterval

emkornfield commented on pull request #7060:
URL: https://github.com/apache/arrow/pull/7060#issuecomment-621628276


   In principal this looks ok to me.  It seems like there is at least one place that was missed /arrow/cpp/src/gandiva/jni/expression_registry_helper.cc:141:10: error: ‘INTERVAL’ is not a member of ‘arrow::Type::type’
   
   As long as the flatbuffers doesn't change, I'm OK with this.  Might be worth sending a mail out to dev@ just to make people aware of it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org