You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 17:42:00 UTC
[GitHub] [airflow] potiuk opened a new pull request #21998: Remove misleading MSSQL information from the docs
potiuk opened a new pull request #21998:
URL: https://github.com/apache/airflow/pull/21998
Some of the past cherry-picks brought MSSQL information to Airflow
docs in stable version. This should be removed.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham edited a comment on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
jedcunningham edited a comment on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059467519
All good, I just started poking around because I didn't know how it got there either and was worried I goofed up 👍
I guess for 2.3.0 we have to either decide to officially support it, tag it as experimental in those howto docs, or remove the docs from main, otherwise we will have the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#discussion_r819855034
##########
File path: docs/apache-airflow/howto/set-up-database.rst
##########
@@ -27,14 +27,13 @@ The document below describes the database engine configurations, the necessary c
Choosing database backend
-------------------------
-If you want to take a real test drive of Airflow, you should consider setting up a database backend to **PostgreSQL**, **MySQL**, or **MSSQL**.
+If you want to take a real test drive of Airflow, you should consider setting up a database backend to **PostgreSQL**, **MySQL**.
Review comment:
too late :) . But yeah. It makes sense also without :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21998:
URL: https://github.com/apache/airflow/pull/21998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059463175
> I certainly don't have a complete history here, but it does look like it was intentionally added before 2.2.0 and wasn't a result of a rogue cherry-pick:
>
> #17018
Right. I have not checked exactly (Assumed it was a cherry-pick) but it is misleading our users (as we do not support MsSQl in any released version of Airflow yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059463661
BTW. @jedcunningham - I assumed it was MY wrong cherry-pick to be precise :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059401971
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059474562
> I guess for 2.3.0 we have to either decide to officially support it, tag it as experimental in those howto docs, or remove the docs from main, otherwise we will have the same issue.
Absolutely. Taking into account a number of issues, experimental I'd say :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on a change in pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
malthe commented on a change in pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#discussion_r819849329
##########
File path: docs/apache-airflow/howto/set-up-database.rst
##########
@@ -27,14 +27,13 @@ The document below describes the database engine configurations, the necessary c
Choosing database backend
-------------------------
-If you want to take a real test drive of Airflow, you should consider setting up a database backend to **PostgreSQL**, **MySQL**, or **MSSQL**.
+If you want to take a real test drive of Airflow, you should consider setting up a database backend to **PostgreSQL**, **MySQL**.
Review comment:
Or?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059467519
All good, I just started poking around because I didn't know how it got there either and was worried I goofed up 👍
I guess for 2.3.0 we have to either decide to adopt support, tag it as experimental in those howto docs, or remove the docs from main, otherwise we will have the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #21998: Remove misleading MSSQL information from the docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #21998:
URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059456434
I certainly don't have a complete history here, but it does look like it was intentionally added before 2.2.0 and wasn't a result of a rogue cherry-pick:
https://github.com/apache/airflow/issues/17018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org