[tinkerpop] 01/03: Merge branch 'TINKERPOP-1921' into tp33

[sp...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git

commit 39e9a4c78f0b453644b1b9a20406e0925ee4da22
Merge: b355d87 9f369ed
Author: Stephen Mallette <sp...@genoprime.com>
AuthorDate: Tue Jul 23 07:19:12 2019 -0400

    Merge branch 'TINKERPOP-1921' into tp33

 CHANGELOG.asciidoc                                 |  1 +
 docs/src/upgrade/release-3.3.x.asciidoc            |  8 +++++
 .../Process/Traversal/DefaultTraversal.cs          | 29 +++++++++++++++--
 .../Gremlin.Net/Process/Traversal/ITraversal.cs    |  6 ++++
 .../Process/Traversal/TraversalTests.cs            | 18 +++++++++++
 gremlin-javascript/glv/TraversalSource.template    | 12 ++++++++
 .../gremlin-javascript/lib/process/traversal.js    | 12 ++++++++
 .../test/integration/traversal-test.js             |  9 ++++--
 .../gremlin-javascript/test/unit/traversal-test.js | 36 ++++++++++++++++++++++
 9 files changed, 126 insertions(+), 5 deletions(-)

diff --cc docs/src/upgrade/release-3.3.x.asciidoc
index 6a87743,c262d4d..5887c74
--- a/docs/src/upgrade/release-3.3.x.asciidoc
+++ b/docs/src/upgrade/release-3.3.x.asciidoc
@@@ -64,38 -64,14 +64,46 @@@ Gremlin steps that require a `GraphComp
  
  See: link:https://issues.apache.org/jira/browse/TINKERPOP-2251[TINKERPOP-2251]
  
+ ==== JavaScript and .NET hasNext()
+ 
+ There is now greater consistency across Gremlin Language Variants with `hasNext()` support added to both JavaScript
+ and .NET. Note that in .NET, the proper method name follows C# capitalization semantics and is referred to as
+ `HasNext()`.
+ 
+ See: link:https://issues.apache.org/jira/browse/TINKERPOP-1921[TINKERPOP-1921]
+ 
 +==== Deprecated getSideEffects()
 +
 +`Traversal.getSideEffects()` has been deprecated for purposes of external calls by end-users. While the method is still
 +present TinkerPop no longer guarantees its existence in future versions or consistency of its behavior, especially for
 +Gremlin Language Variants and remote traversal execution. If this method is currently in use to gather side-effect
 +results after traversal execution, please change such code to use `cap()`-step. For example, code like this:
 +
 +[source,text]
 +----
 +gremlin> t = g.V().hasLabel('person').aggregate('p').out('created')
 +==>v[3]
 +==>v[5]
 +==>v[3]
 +==>v[3]
 +gremlin> t.getSideEffects().get('p')
 +==>v[1]
 +==>v[2]
 +==>v[4]
 +==>v[6]
 +----
 +
 +should be converted to something like:
 +
 +[source,text]
 +----
 +gremlin> g.V().hasLabel('person').aggregate('p').out('created').union(fold(),cap('p'))
 +==>[v[3],v[3],v[3],v[5]]
 +==>[v[1],v[2],v[4],v[6]]
 +----
 +
 +link:https://issues.apache.org/jira/browse/TINKERPOP-2265[TINKERPOP-2265]
 +
  == TinkerPop 3.3.7
  
  *Release Date: May 28, 2019*