[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2446: [KYUUBI #2433] Hive default load required jars

[GitBox <gi...@apache.org>]

yaooqinn commented on code in PR #2446:
URL: https://github.com/apache/incubator-kyuubi/pull/2446#discussion_r856058218


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/hive/HiveProcessBuilder.scala:
##########
@@ -81,16 +81,25 @@ class HiveProcessBuilder(
     extraCp.foreach(classpathEntries.add)
     if (extraCp.isEmpty) {
       warn(s"The conf of kyuubi.engine.hive.extra.classpath is empty.")
-      mainResource.foreach { path =>
-        val devHadoopJars = Paths.get(path).getParent
-          .resolve(s"scala-$SCALA_COMPILE_VERSION")
-          .resolve("jars")
-        if (!Files.exists(devHadoopJars)) {
-          throw new KyuubiException(s"The path $devHadoopJars does not exists. Please set " +
-            s"kyuubi.engine.hive.extra.classpath for configuring location of " +
-            s"hadoop client jars, etc")
+      val distJars = new File(s"${env.get(KYUUBI_HOME).orNull}${File.separator}jars")

Review Comment:
   Kyuubi Server lib is designed isolated with engine jars, if we mix them it's hard to maintain in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org