[GitHub] [airflow] ashb commented on a change in pull request #15929: Fail tasks in scheduler when executor reports they failed

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #15929:
URL: https://github.com/apache/airflow/pull/15929#discussion_r634746031



##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -907,13 +907,13 @@ def test_process_executor_events(self, mock_stats_incr, mock_task_callback):
 
         self.scheduler_job._process_executor_events(session=session)
         ti1.refresh_from_db()
-        assert ti1.state == State.QUEUED
+        assert ti1.state == State.FAILED
         mock_task_callback.assert_called_once_with(
             full_filepath='/test_path1/',
             simple_task_instance=mock.ANY,
             msg='Executor reports task instance '
-            '<TaskInstance: test_process_executor_events.dummy_task 2016-01-01 00:00:00+00:00 [queued]> '
-            'finished (failed) although the task says its queued. (Info: None) '
+            '<TaskInstance: test_process_executor_events.dummy_task 2016-01-01 00:00:00+00:00 [failed]> '
+            'finished (failed) although the task says its failed. (Info: None) '

Review comment:
       Hmmm, this log message now doesn't make any sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org