You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/13 17:56:30 UTC
[GitHub] [kafka] hachikuji opened a new pull request, #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs
hachikuji opened a new pull request, #12162:
URL: https://github.com/apache/kafka/pull/12162
In the AlterConfigs/IncrementalAlterConfigs zk handler, we return `INVALID_REQUEST` and `INVALID_CONFIG` inconsistently. The problem is in `LogConfig.validate`. We may either return `ConfigException` or `InvalidConfigException`. When the first of these is thrown, we catch it and convert to INVALID_REQUEST. If the latter is thrown, then we return `INVALID_CONFIG`. It seems more appropriate to return INVALID_CONFIG consistently. Note that the KRaft implementation already does this.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs
Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12162:
URL: https://github.com/apache/kafka/pull/12162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs
Posted by GitBox <gi...@apache.org>.
dengziming commented on PR #12162:
URL: https://github.com/apache/kafka/pull/12162#issuecomment-1126923364
This is similar to [KAFKA-13609](https://issues.apache.org/jira/browse/KAFKA-13609), do we need a KIP for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12162:
URL: https://github.com/apache/kafka/pull/12162#issuecomment-1128281035
@dengziming By the way, KAFKA-13609 seems to apply to broker configurations. Similarly, I do not think we need a KIP since INVALID_CONFIG is already used by these APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on pull request #12162: KAFKA-13899: Use INVALID_CONFIG error code consistently in AlterConfig APIs
Posted by GitBox <gi...@apache.org>.
hachikuji commented on PR #12162:
URL: https://github.com/apache/kafka/pull/12162#issuecomment-1127889552
@dengziming I am thinking not. We already raise INVALID_CONFIG in some cases and it was documented explicitly in at least the IncrementalAlterConfig KIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org