[jira] [Comment Edited] (HBASE-3188) Review locking around AssignmentManager.regionPlans

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021450#comment-14021450 ] 

Andrew Purtell edited comment on HBASE-3188 at 6/8/14 10:05 PM:
----------------------------------------------------------------

Stale 


was (Author: apurtell):
Stale issue. Reopen if still relevant (if there's new activity)

> Review locking around AssignmentManager.regionPlans
> ---------------------------------------------------
>
>                 Key: HBASE-3188
>                 URL: https://issues.apache.org/jira/browse/HBASE-3188
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.90.0
>            Reporter: Jonathan Gray
>            Priority: Minor
>
> AssignmentManager.regionPlans is currently a ConcurrentSkipListMap so does not require synchronization.  But sometimes we do multiple operations and we synchronize on it.  But other times we don't synchronize on it at all.
> Let's review and make sure we're doing the right thing.
> Also see if we still need this AssignmentManager.updateTimers().  Don't we disable load balancer / expiration during startup or no?



--
This message was sent by Atlassian JIRA
(v6.2#6252)