You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "GUIDINGLI (via GitHub)" <gi...@apache.org> on 2024/03/01 14:59:13 UTC

[PR] poll: fix thread_cancel() caused poll used after free [nuttx]

GUIDINGLI opened a new pull request, #11811:
URL: https://github.com/apache/nuttx/pull/11811

   ## Summary
   
   poll: fix thread_cancel() caused poll used after free
   
   ```
       pthread 0          pthread1
       fd 0
       poll_setup
       wait
                          cancel(thread 0)
                          fd 0 close
                          fd 0 notify (sem used after free)
       poll_teardown
   ```
       
   Resolve:
   Use pthread_cleanup / tls_cleanup to fix this
   
   ## Impact
   
   POLL
   
   ## Testing
   
   SIM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] poll: fix thread_cancel() caused poll used after free [nuttx]

Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on PR #11811:
URL: https://github.com/apache/nuttx/pull/11811#issuecomment-1977988702

   @GUIDINGLI Is CONFIG_PTHREAD_CLEANUP_STACKSIZE->CONFIG_TLS_NCLEANUP  going to break everyone's out of repo code? 
   Should it be marked as a breaking change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] poll: fix thread_cancel() caused poll used after free [nuttx]

Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI closed pull request #11811: poll: fix thread_cancel() caused poll used after free
URL: https://github.com/apache/nuttx/pull/11811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] poll: fix thread_cancel() caused poll used after free [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #11811:
URL: https://github.com/apache/nuttx/pull/11811#issuecomment-1975588882

   @liguiding Please rebase to the last master which fix the ci broken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] poll: fix thread_cancel() caused poll used after free [nuttx]

Posted by "GUIDINGLI (via GitHub)" <gi...@apache.org>.
GUIDINGLI commented on PR #11811:
URL: https://github.com/apache/nuttx/pull/11811#issuecomment-2325860678

   > @GUIDINGLI Is CONFIG_PTHREAD_CLEANUP_STACKSIZE->CONFIG_TLS_NCLEANUP going to break everyone's out of repo code? Should it be marked as a breaking change?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org