[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...

[jhsenjaliya <gi...@git.apache.org>]

Github user jhsenjaliya commented on a diff in the pull request:

    https://github.com/apache/eagle/pull/941#discussion_r119687625
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
    @@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
                 velocityEngine = new VelocityEngine();
                 velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
                 velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
    +            velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
    --- End diff --
    
    I believe, right way to fix this would be
    ```
    velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, org.apache.velocity.runtime.log.Log4JLogChute.class.getName());
    velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---