You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2023/01/18 15:00:24 UTC
[GitHub] [couchdb] janl opened a new pull request, #4386: chore(readme): update mac dev install instructions
janl opened a new pull request, #4386:
URL: https://github.com/apache/couchdb/pull/4386
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provide any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affect multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] Documentation changes were made in the `src/docs` folder
- [ ] Documentation changes were backported (separated PR) to affected branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] pgj commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1095856584
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
I am not sure even if Python needs to be installed via `brew`. The `xcode-select --install` command would add Python 3 and `pip3`, which are of versions 3.9.6 and 21.2.4 respectively at the moment (Ventura 13.1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1096567629
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
Let's merge it. It looks good. I have PR for docs setup+readme to use pip3 instead of pip https://github.com/apache/couchdb/pull/4415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1095843155
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
right, but on homebrew python, `pip` doesn’t exist and instead there is `pip3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1073714355
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
Technically for doc for local dev just having python3 with pip is enough. We do most of the requirements in a venv anyway https://github.com/apache/couchdb/tree/main/src/docs https://github.com/apache/couchdb/blob/main/src/docs/requirements.txt
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
Technically, for docs for local dev just having python3 with pip is enough. We do most of the requirements in a venv anyway https://github.com/apache/couchdb/tree/main/src/docs https://github.com/apache/couchdb/blob/main/src/docs/requirements.txt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1095848616
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
or are you suggesting that whole line can go? (suggested inline patches = <3 ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1096545970
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
what do y’all want me to do with this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1095896353
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
I ran into issues with the built-in python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4386: chore(readme): update mac dev install instructions
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4386:
URL: https://github.com/apache/couchdb/pull/4386#discussion_r1095915657
##########
README-DEV.rst:
##########
@@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section.
Install what else we can with Homebrew::
- brew install help2man gnupg md5sha1sum node python
+ brew install \
+ erlang \
+ elixir \
+ help2man \
+ node \
+ python \
+ spidermonkey
-If you don't already have pip installed, install it::
-
- sudo easy_install pip
Now, install the required Python packages::
- sudo pip install sphinx docutils pygments sphinx_rtd_theme
+ pip3 install sphinx docutils pygments sphinx_rtd_theme
Review Comment:
I think we can update the [src/docs](https://github.com/apache/couchdb/tree/main/src/docs) to use `pip3`. I probably just had pip linked to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org