You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/13 08:11:30 UTC
[GitHub] [apisix] sober-wang opened a new pull request #2408: The old CLI invalid argument prompt is unfriendly.
sober-wang opened a new pull request #2408:
URL: https://github.com/apache/apisix/pull/2408
### What this PR does / why we need it:
Because the old CLI invalid argument prompt is unfriendly. So I modify it, next look like friendly.
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
No . maybe you can used the CLI
```shell
apisix --help
```
* [x] Have you modified the corresponding document?
I modified the invalid argument prompt.
* [x] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2408: The old CLI invalid argument prompt is unfriendly.
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2408:
URL: https://github.com/apache/apisix/pull/2408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2408: The old CLI invalid argument prompt is unfriendly.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2408:
URL: https://github.com/apache/apisix/pull/2408#discussion_r503962657
##########
File path: bin/apisix
##########
@@ -1127,6 +1127,7 @@ end
if not _M[cmd_action] then
print("invalid argument: ", cmd_action, "\n")
+ _M.help()
Review comment:
bad indentation
we should use 4 spaces here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2408: The old CLI invalid argument prompt is unfriendly.
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2408:
URL: https://github.com/apache/apisix/pull/2408#issuecomment-711605284
@sober-wang many thx, merged already
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org