You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/05/10 14:19:20 UTC

Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-20980
    https://issues.apache.org/jira/browse/AMBARI-20980


Repository: ambari


Description
-------

STR:
# Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
# Enable NN HA
# Upgrade ambari to 2.5.1.0-95
# Register and install HDP 2.6.1.0-56
# Perform RU to Finalize
# Perform Downgrade
Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade


std.err
{code}
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
SparkClient().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
method(env)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
import params
File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
livy2_pid_dir = status_params.livy2_pid_dir
AttributeError: 'module' object has no attribute 'livy2_pid_dir'
{code}

it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.


Diffs
-----

  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 4ed0718 


Diff: https://reviews.apache.org/r/59144/diff/1/


Testing
-------

mvn clean test

Also checked  2.5->2.6->2.6


Thanks,

Dmitro Lisnichenko


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174552
-----------------------------------------------------------


Ship it!




Fix looks good - just make sure there's not another place to change this as Alejandro mentioned.

- Jonathan Hurley


On May 10, 2017, 10:19 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 10:19 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 4ed0718 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On May 10, 2017, 8:56 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
> > Line 201 (original), 201 (patched)
> > <https://reviews.apache.org/r/59144/diff/1/?file=1714012#file1714012line201>
> >
> >     Is the same change needed in ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts ?

thanks, added


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174516
-----------------------------------------------------------


On May 11, 2017, 5:09 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 5:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py cd556d76bb 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py e508a0ddbc 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On May 10, 2017, 5:56 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
> > Line 201 (original), 201 (patched)
> > <https://reviews.apache.org/r/59144/diff/1/?file=1714012#file1714012line201>
> >
> >     Is the same change needed in ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts ?
> 
> Dmitro Lisnichenko wrote:
>     thanks, added
> 
> Alejandro Fernandez wrote:
>     I don't see this in https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py

Nevermind.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174516
-----------------------------------------------------------


On May 11, 2017, 2:09 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 2:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py cd556d76bb 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py e508a0ddbc 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Alejandro Fernandez <af...@hortonworks.com>.

> On May 10, 2017, 5:56 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
> > Line 201 (original), 201 (patched)
> > <https://reviews.apache.org/r/59144/diff/1/?file=1714012#file1714012line201>
> >
> >     Is the same change needed in ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts ?
> 
> Dmitro Lisnichenko wrote:
>     thanks, added

I don't see this in https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts/params.py


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174516
-----------------------------------------------------------


On May 11, 2017, 2:09 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 2:09 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py cd556d76bb 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py e508a0ddbc 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174516
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
Line 201 (original), 201 (patched)
<https://reviews.apache.org/r/59144/#comment247672>

    Is the same change needed in ambari-server/src/main/resources/common-services/SPARK/2.2.0/package/scripts ?


- Alejandro Fernandez


On May 10, 2017, 2:19 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 2:19 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 4ed0718 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174649
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On May 11, 2017, 10:09 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py cd556d76bb 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py e508a0ddbc 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/2/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/
-----------------------------------------------------------

(Updated May 11, 2017, 5:09 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-20980
    https://issues.apache.org/jira/browse/AMBARI-20980


Repository: ambari


Description
-------

STR:
# Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
# Enable NN HA
# Upgrade ambari to 2.5.1.0-95
# Register and install HDP 2.6.1.0-56
# Perform RU to Finalize
# Perform Downgrade
Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade


std.err
{code}
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
SparkClient().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
method(env)
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
import params
File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
livy2_pid_dir = status_params.livy2_pid_dir
AttributeError: 'module' object has no attribute 'livy2_pid_dir'
{code}

it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/params.py cd556d76bb 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py e508a0ddbc 


Diff: https://reviews.apache.org/r/59144/diff/2/

Changes: https://reviews.apache.org/r/59144/diff/1-2/


Testing
-------

mvn clean test

Also checked  2.5->2.6->2.6


Thanks,

Dmitro Lisnichenko


Re: Review Request 59144: RU: RESTART SPARK2/SPARK2_CLIENT failed

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59144/#review174544
-----------------------------------------------------------


Ship it!




Ship It!

- Nate Cole


On May 10, 2017, 10:19 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59144/
> -----------------------------------------------------------
> 
> (Updated May 10, 2017, 10:19 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-20980
>     https://issues.apache.org/jira/browse/AMBARI-20980
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> STR:
> # Deploy HDP 2.5.3.0-37 on Ambari 2.4.2.0
> # Enable NN HA
> # Upgrade ambari to 2.5.1.0-95
> # Register and install HDP 2.6.1.0-56
> # Perform RU to Finalize
> # Perform Downgrade
> Result: RESTART SPARK2/SPARK2_CLIENT failed during Downgrade
> 
> 
> std.err
> {code}
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 60, in <module>
> SparkClient().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 315, in execute
> method(env)
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 783, in restart
> self.pre_upgrade_restart(env, upgrade_type=upgrade_type)
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/spark_client.py", line 51, in pre_upgrade_restart
> import params
> File "/var/lib/ambari-agent/cache/common-services/SPARK2/2.0.0/package/scripts/params.py", line 209, in <module>
> livy2_pid_dir = status_params.livy2_pid_dir
> AttributeError: 'module' object has no attribute 'livy2_pid_dir'
> {code}
> 
> it was caused by AMBARI-19248 which assumes that livy2_pid_dir is present even if livy2 is not installed.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py 4ed0718 
> 
> 
> Diff: https://reviews.apache.org/r/59144/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> Also checked  2.5->2.6->2.6
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>