[GitHub] [incubator-superset] graceguo-supercat commented on issue #9235: [fix] use filter_scopes in dashboard warmup strategy

[GitBox <gi...@apache.org>]

graceguo-supercat commented on issue #9235: [fix] use filter_scopes in dashboard warmup strategy
URL: https://github.com/apache/incubator-superset/pull/9235#issuecomment-595397919
 
 
   > One comment about your comment. otherwise lgtm.
   > 
   > I think there miiight be unnecessary `.get()` defaults/null checks, but I'm ok with those because they prevent null pointer exceptions.
   
   i agree in most cases this null won't happen. but you know user can direct edit those metadata (instead of code generated). So keep null check won't overkill.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org