You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 15:09:57 UTC

[GitHub] [arrow] assignUser commented on a diff in pull request #13063: MINOR: [C++] Use bundled gtest

assignUser commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r864958276


##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
       -DARROW_WITH_SNAPPY=ON ^
       -DARROW_WITH_ZLIB=ON ^
       -DARROW_WITH_ZSTD=ON ^
+      -DGTest_SOURCE=SYSTEM ^

Review Comment:
   It looks like [it worked](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-2012-github-test-build-vcpkg-win) (vcpkg is still installing 1.10 but the error is gone)? It now fails due to missing tzdata, which should be fixable via the download script



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org