[GitHub] [helix] pkuwm edited a comment on issue #548: Add max capacity usage metric for instance monitor.

[GitBox <gi...@apache.org>]

pkuwm edited a comment on issue #548: Add max capacity usage metric for instance monitor.
URL: https://github.com/apache/helix/pull/548#issuecomment-548992171
 
 
   This PR is ready to be merged, approved by @jiajunwang 
   ```
   We need to monitor instance utilization in purpose of understanding what the max instance capacity usage is and knowing the status of the instance.
   
   Change list:
   1. Change instance monitor to extend dynamic metric, and change code logic in ClusterStatusMonitor to adapt the InstanceMonitor changes.
   2. Add APIs for get/update MaxCapacityUsage.
   3. Add an API in cluster status monitor to update max capacity usage.
   4. Add unit tests for instance monitor and updateing max capacity usage.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org