You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/10 16:04:00 UTC
[jira] [Commented] (FLINK-7415) Add comments for cassandra test
class `BatchExample`
[ https://issues.apache.org/jira/browse/FLINK-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121830#comment-16121830 ]
ASF GitHub Bot commented on FLINK-7415:
---------------------------------------
GitHub user yew1eb opened a pull request:
https://github.com/apache/flink/pull/4519
[FLINK-7415][Cassandra Connector] Add comments for `BatchExample.java`
## What is the purpose of the change
Help beginners follow it with less confusion.
## Brief change log
- Add comments for cassandra batch-test class `BatchExample.java`
## Verifying this change
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yew1eb/flink FLINK-7415
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4519
----
commit 62fbc338f5049bebd5b770f66938b9394677dbe9
Author: yew1eb <ye...@gmail.com>
Date: 2017-08-10T15:28:00Z
add comments for BatchExample.java
----
> Add comments for cassandra test class `BatchExample`
> ----------------------------------------------------
>
> Key: FLINK-7415
> URL: https://issues.apache.org/jira/browse/FLINK-7415
> Project: Flink
> Issue Type: Test
> Components: Cassandra Connector
> Reporter: Hai Zhou
>
> In `org.apache.flink.batch.connectors.cassandra.example.BatchExample`description:
> {code:java}
> * <p>The example assumes that a table exists in a local cassandra database, according to the following query:
> * CREATE TABLE test.batches (number int, strings text, PRIMARY KEY(number, strings));
> */
> {code}
> The Keyspace 'test' not exist,We should create it at first.
> I will improve its description.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)