You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nathan Hartman <ha...@gmail.com> on 2021/05/26 13:00:20 UTC
Re: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw
On Wed, May 26, 2021 at 8:31 AM <rh...@apache.org> wrote:
> Author: rhuijben
> Date: Wed May 26 12:31:05 2021
> New Revision: 1890223
>
> URL: http://svn.apache.org/viewvc?rev=1890223&view=rev
> Log:
> * subversion/svn_private_config.hw
> Properly identify Windows on ARM/ARM64, instead of breaking the build.
>
> Modified:
> subversion/trunk/subversion/svn_private_config.hw
>
> Modified: subversion/trunk/subversion/svn_private_config.hw
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/svn_private_config.hw?rev=1890223&r1=1890222&r2=1890223&view=diff
>
> ==============================================================================
> --- subversion/trunk/subversion/svn_private_config.hw (original)
> +++ subversion/trunk/subversion/svn_private_config.hw Wed May 26 12:31:05
> 2021
> @@ -39,6 +39,10 @@
> #define SVN_BUILD_TARGET "ia64-microsoft-windows"
> #elif defined( _M_IX86)
> #define SVN_BUILD_TARGET "x86-microsoft-windows"
> +#elif defined(_M_ARM64)
> +#define SVN_BUILD_TARGET "arm64-microsoft-windows"
> +#elif defined(_M_ARM)
> +#define SVN_BUILD_TARGET "arm-microsoft-windows"
> #else
> #error Unsupported build target.
> #endif
This looks like it should be nominated for backport, though I don't have an
ARM Windows machine to test with.
Nathan
Re: svn commit: r1890223 -
/subversion/trunk/subversion/svn_private_config.hw
Posted by Bert Huijben <be...@qqmail.nl>.
Most buildsystems on Windows assumed just Win32 and the usual win64-x64, and ARM64 is a different beast... An on top of that you usually cross compile.
But I got confirmation that the binaries work great on these systems... It got through all the python+c tests except the 2 or 3 common failures we also see when setting up new bots.
Bert
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Daniel Shahaf <d....@daniel.shahaf.name>
Sent: Thursday, May 27, 2021 7:50:13 PM
To: Bert Huijben <be...@qqmail.nl>
Cc: dev@subversion.apache.org <de...@subversion.apache.org>
Subject: Re: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw
bert@qqmail.nl wrote on Thu, 27 May 2021 11:51 +00:00:
> We will need a few more patches to really support ARM64 builds. Once I
> get things working I’ll add a pull request.
Neither backport.pl nor backport.py support pull requests, so the RM
would have to merge it manually.
> Most likely I will release a SlikSvn client release for ARM64 with that
> support if everything comes together… But cross compiling on Windows is
> quite new for most of our dependencies, and ARM64 is new as well so
> most dependencies need patches (except for those building via CMake)
Is the relation between not needing patches and using CMake merely
correlation or also causation?
Cheers,
Daniel
Re: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
bert@qqmail.nl wrote on Thu, 27 May 2021 11:51 +00:00:
> We will need a few more patches to really support ARM64 builds. Once I
> get things working I’ll add a pull request.
Neither backport.pl nor backport.py support pull requests, so the RM
would have to merge it manually.
> Most likely I will release a SlikSvn client release for ARM64 with that
> support if everything comes together… But cross compiling on Windows is
> quite new for most of our dependencies, and ARM64 is new as well so
> most dependencies need patches (except for those building via CMake)
Is the relation between not needing patches and using CMake merely
correlation or also causation?
Cheers,
Daniel
RE: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw
Posted by be...@qqmail.nl.
We will need a few more patches to really support ARM64 builds. Once I get things working I’ll add a pull request.
Most likely I will release a SlikSvn client release for ARM64 with that support if everything comes together… But cross compiling on Windows is quite new for most of our dependencies, and ARM64 is new as well so most dependencies need patches (except for those building via CMake)
Bert
Van: Nathan Hartman <ha...@gmail.com>
Verzonden: woensdag 26 mei 2021 15:00
Aan: dev@subversion.apache.org
Onderwerp: Re: svn commit: r1890223 - /subversion/trunk/subversion/svn_private_config.hw
On Wed, May 26, 2021 at 8:31 AM <rhuijben@apache.org <ma...@apache.org> > wrote:
Author: rhuijben
Date: Wed May 26 12:31:05 2021
New Revision: 1890223
URL: http://svn.apache.org/viewvc?rev=1890223 <http://svn.apache.org/viewvc?rev=1890223&view=rev> &view=rev
Log:
* subversion/svn_private_config.hw
Properly identify Windows on ARM/ARM64, instead of breaking the build.
Modified:
subversion/trunk/subversion/svn_private_config.hw
Modified: subversion/trunk/subversion/svn_private_config.hw
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn_private_config.hw?rev=1890223 <http://svn.apache.org/viewvc/subversion/trunk/subversion/svn_private_config.hw?rev=1890223&r1=1890222&r2=1890223&view=diff> &r1=1890222&r2=1890223&view=diff
==============================================================================
--- subversion/trunk/subversion/svn_private_config.hw (original)
+++ subversion/trunk/subversion/svn_private_config.hw Wed May 26 12:31:05 2021
@@ -39,6 +39,10 @@
#define SVN_BUILD_TARGET "ia64-microsoft-windows"
#elif defined( _M_IX86)
#define SVN_BUILD_TARGET "x86-microsoft-windows"
+#elif defined(_M_ARM64)
+#define SVN_BUILD_TARGET "arm64-microsoft-windows"
+#elif defined(_M_ARM)
+#define SVN_BUILD_TARGET "arm-microsoft-windows"
#else
#error Unsupported build target.
#endif
This looks like it should be nominated for backport, though I don't have an ARM Windows machine to test with.
Nathan