You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2018/10/01 21:14:25 UTC

[kudu-CR] Fix Pandas Tests in Python 2.6 client\n\n This is to resolve issues with the pandas tests in the kudu-python\n client. Pandas must be installed in the virtualenv for python2.6\n for test but we don't want to make it a requirement in\n requirements.txt. We 

andy@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11557


Change subject: Fix Pandas Tests in Python 2.6 client\n\n This is to resolve issues with the pandas tests in the kudu-python\n client. Pandas must be installed in the virtualenv for python2.6\n for test but we don't want to make it a requirement in\n requirements.txt. We
......................................................................

Fix Pandas Tests in Python 2.6 client\n\n
This is to resolve issues with the pandas tests in the kudu-python\n
client. Pandas must be installed in the virtualenv for python2.6\n
for test but we don't want to make it a requirement in\n
requirements.txt. We will put the pandas dependecny in the jenkins\n
build-and-test.sh as a workaround. This is based on the intial\n
work done here https://gerrit.cloudera.org/#/c/10809/4

Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
M python/requirements.txt
M python/setup.py
4 files changed, 18 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/11557/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 1
Gerrit-Owner: andy@phdata.io

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Remove Pandas as a Python Client Requirement
......................................................................

Remove Pandas as a Python Client Requirement

This is to remove the pandas dependency for users.
We will put the pandas dependency in the jenkins script
build-and-test.sh as a workaround. This is based on the initial
work done here https://gerrit.cloudera.org/#/c/10809/4

Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Reviewed-on: http://gerrit.cloudera.org:8080/11557
Tested-by: Kudu Jenkins
Reviewed-by: Jordan Birdsell <jt...@apache.org>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
M python/requirements.txt
M python/setup.py
4 files changed, 23 insertions(+), 12 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Jordan Birdsell: Looks good to me, but someone else must approve
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 6
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io

[kudu-CR] Fix Pandas Tests in Python 2.6 client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Fix Pandas Tests in Python 2.6 client
......................................................................


Patch Set 3:

(7 comments)

I guess I don't really understand; requirements.txt is only mandatory on a machine where you're building kudu-python. Anyone who runs 'pip install kudu-python' isn't going to interact with requirements.txt (or with tests_require for that matter), right? Why is it onerous for pandas to be a requirement when building kudu-python?

http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG@12
PS3, Line 12: requirements.txt. We will put the pandas dependecny in the jenkins
dependency


http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG@13
PS3, Line 13: intial
initial


http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@506
PS3, Line 506:   # We need to install Pandas manually since its not a required package but is needed
Nit: it's

Also terminate with a period.

Below too.


http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@508
PS3, Line 508:   pip install pandas
Can you pin this to 0.18, which was the last version to support Python 2.6? Also please preserve the breadcrumb comment from requirements.txt; it's useful for people who want to learn more.

Also, can you add $PIP_INSTALL_FLAGS after 'pip install'? Below too.


http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@567
PS3, Line 567:   
Nit: leading whitespace here.


http://gerrit.cloudera.org:8080/#/c/11557/3/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

http://gerrit.cloudera.org:8080/#/c/11557/3/python/kudu/tests/test_scanner.py@385
PS3, Line 385:     @pytest.mark.skipif((not(kudu.CLIENT_SUPPORTS_PANDAS) and
             :                             (not(kudu.CLIENT_SUPPORTS_DECIMAL))),
Can this be formatted like this?

  @pytest.mark.skipif(not (kudu.CLIENT_SUPPORTS_PANDAS) and
                      not (kudu.CLIENT_SUPPORTS_DECIMAL)),


http://gerrit.cloudera.org:8080/#/c/11557/3/python/setup.py
File python/setup.py:

http://gerrit.cloudera.org:8080/#/c/11557/3/python/setup.py@197
PS3, Line 197:     # pytest 3.3 [1], pytest-timeout 1.2.1 [2], and pandas 0.18 [3] dropped
             :     # support for python 2.6.
             :     #
             :     # 1. https://docs.pytest.org/en/latest/changelog.html#id164
             :     # 2. https://pypi.org/project/pytest-timeout/#id5
             :     # 3. https://pandas.pydata.org/pandas-docs/version/0.23.0/whatsnew.html#v0-18-0-march-13-2016
Update this to remove the pandas reference.



-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 01 Oct 2018 22:28:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
andy@phdata.io has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Remove Pandas as a Python Client Requirement
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG@13
PS3, Line 13: 
> initial
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 5
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io
Gerrit-Comment-Date: Thu, 04 Oct 2018 15:18:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix Pandas Tests in Python 2.6 client This is to resolve issues with the pandas tests in the kudu-python client. Pandas must be installed in the virtualenv for python2.6 for test but we don't want to make it a requirement in requirements.txt. We will put

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11557

to look at the new patch set (#2).

Change subject: Fix Pandas Tests in Python 2.6 client This is to resolve issues with the pandas tests in the kudu-python client. Pandas must be installed in the virtualenv for python2.6 for test but we don't want to make it a requirement in requirements.txt. We will put 
......................................................................

Fix Pandas Tests in Python 2.6 client
This is to resolve issues with the pandas tests in the kudu-python
client. Pandas must be installed in the virtualenv for python2.6
for test but we don't want to make it a requirement in
requirements.txt. We will put the pandas dependecny in the jenkins
build-and-test.sh as a workaround. This is based on the intial
work done here https://gerrit.cloudera.org/#/c/10809/4

Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
M python/requirements.txt
M python/setup.py
4 files changed, 18 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/11557/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 2
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Fix Pandas Tests in Python 2.6 client

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Jordan Birdsell, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11557

to look at the new patch set (#3).

Change subject: Fix Pandas Tests in Python 2.6 client
......................................................................

Fix Pandas Tests in Python 2.6 client

This is to resolve issues with the pandas tests in the kudu-python
client. Pandas must be installed in the virtualenv for python2.6
for test but we don't want to make it a requirement in
requirements.txt. We will put the pandas dependecny in the jenkins
build-and-test.sh as a workaround. This is based on the intial
work done here https://gerrit.cloudera.org/#/c/10809/4

Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
M python/requirements.txt
M python/setup.py
4 files changed, 18 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/11557/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Remove Pandas as a Python Client Requirement
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@506
PS3, Line 506:   # We need to install Pandas manually since its not a required package but is needed
> Done
Missed its -> it's. But not a big deal.



-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 5
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io
Gerrit-Comment-Date: Thu, 04 Oct 2018 18:17:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] Fix Pandas Tests in Python 2.6 client

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Fix Pandas Tests in Python 2.6 client
......................................................................


Patch Set 3:

Yep, makes sense


-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 02 Oct 2018 00:04:02 +0000
Gerrit-HasComments: No

[kudu-CR] Fix Pandas Tests in Python 2.6 client

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Fix Pandas Tests in Python 2.6 client
......................................................................


Patch Set 3:

You could flip the argument here and ask why would it be too difficult for developers looking to test pandas integration to install pandas?  I suppose we could get away with leaving it in requirements.txt and removing it from setup.py, however, if forced to pick between the two options, I'd say this introduces unnecessary confusion.


-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 01 Oct 2018 23:24:27 +0000
Gerrit-HasComments: No

[kudu-CR] Fix Pandas Tests in Python 2.6 client

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Fix Pandas Tests in Python 2.6 client
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> You could flip the argument here and ask why would it be too difficult for developers looking to test pandas integration to install pandas?  I suppose we could get away with leaving it in requirements.txt and removing it from setup.py, however, if forced to pick between the two options, I'd say this introduces unnecessary confusion.

To be clear, I don't have a strong opinion on the matter, and I'm not opposed to this change. I was just trying to understand the motivation; I figured maybe I overlooked something in how kudu-client was built, tested, or deployed.

However, I do think if we're going to leave pandas in requirements.txt, we should also leave it in setup.py. That's because I think it's valuable for "pip install -r requirements.txt" to install both build and test dependencies; "python setup.py test" can certainly download dependencies listed in tests_require, but it's harder to control that process (e.g. it's harder to choose an alternate mirror).


-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 3
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 01 Oct 2018 23:30:28 +0000
Gerrit-HasComments: No

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
andy@phdata.io has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Remove Pandas as a Python Client Requirement
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11557/3//COMMIT_MSG@12
PS3, Line 12: work done here https://gerrit.cloudera.org/#/c/10809/4
> dependency
Done


http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@506
PS3, Line 506:   # We need to install Pandas manually since its not a required package but is needed
> Nit: it's
Done


http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@508
PS3, Line 508:   # pandas 0.18 dropped support for python 2.6.
> Can you pin this to 0.18, which was the last version to support Python 2.6?
Done


http://gerrit.cloudera.org:8080/#/c/11557/3/build-support/jenkins/build-and-test.sh@567
PS3, Line 567:   #
> Nit: leading whitespace here.
Done


http://gerrit.cloudera.org:8080/#/c/11557/3/python/kudu/tests/test_scanner.py
File python/kudu/tests/test_scanner.py:

http://gerrit.cloudera.org:8080/#/c/11557/3/python/kudu/tests/test_scanner.py@385
PS3, Line 385:     @pytest.mark.skipif((not(kudu.CLIENT_SUPPORTS_PANDAS) and
             :                         (not(kudu.CLIENT_SUPPORTS_DECIMAL))),
> Can this be formatted like this?
Done


http://gerrit.cloudera.org:8080/#/c/11557/3/python/setup.py
File python/setup.py:

http://gerrit.cloudera.org:8080/#/c/11557/3/python/setup.py@197
PS3, Line 197:     # pytest 3.3 [1] and pytest-timeout 1.2.1 [2] dropped
             :     # support for python 2.6.
             :     #
             :     # 1. https://docs.pytest.org/en/latest/changelog.html#id164
             :     # 2. https://pypi.org/project/pytest-timeout/#id5
             :     tests_require=['pytest >=2.8,<3.3',
> Update this to remove the pandas reference.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 4
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io
Gerrit-Comment-Date: Thu, 04 Oct 2018 15:17:22 +0000
Gerrit-HasComments: Yes

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11557 )

Change subject: Remove Pandas as a Python Client Requirement
......................................................................


Patch Set 5: Code-Review+1

I'm good with this change but would like someone else to provide the 2nd +1 since there has been a lot of feedback here.


-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 5
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io
Gerrit-Comment-Date: Thu, 04 Oct 2018 18:02:01 +0000
Gerrit-HasComments: No

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Jordan Birdsell, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11557

to look at the new patch set (#4).

Change subject: Remove Pandas as a Python Client Requirement
......................................................................

Remove Pandas as a Python Client Requirement

This is to remove the pandas dependency for users.
We will put the pandas dependency in the jenkins script
build-and-test.sh as a workaround. This is based on the intial
work done here https://gerrit.cloudera.org/#/c/10809/4

Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
M python/requirements.txt
M python/setup.py
4 files changed, 23 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/11557/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 4
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Remove Pandas as a Python Client Requirement

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Jordan Birdsell, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11557

to look at the new patch set (#5).

Change subject: Remove Pandas as a Python Client Requirement
......................................................................

Remove Pandas as a Python Client Requirement

This is to remove the pandas dependency for users.
We will put the pandas dependency in the jenkins script
build-and-test.sh as a workaround. This is based on the initial
work done here https://gerrit.cloudera.org/#/c/10809/4

Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
---
M build-support/jenkins/build-and-test.sh
M python/kudu/tests/test_scanner.py
M python/requirements.txt
M python/setup.py
4 files changed, 23 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/11557/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cce7d529a804e712ccc32fb2774f5d0ee9dbdf8
Gerrit-Change-Number: 11557
Gerrit-PatchSet: 5
Gerrit-Owner: andy@phdata.io
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jordan Birdsell <jt...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: andy@phdata.io