You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by xh...@apache.org on 2020/03/28 19:26:33 UTC
[incubator-pinot] branch master updated: [TE] frontend -
harleyjj/alert-details - show bounds for minute granularity again (#5192)
This is an automated email from the ASF dual-hosted git repository.
xhsun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 772f51e [TE] frontend - harleyjj/alert-details - show bounds for minute granularity again (#5192)
772f51e is described below
commit 772f51e26336d4ad07296ad5d9fff85b739754c0
Author: Harley Jackson <hj...@linkedin.com>
AuthorDate: Sat Mar 28 12:26:21 2020 -0700
[TE] frontend - harleyjj/alert-details - show bounds for minute granularity again (#5192)
---
.../thirdeye-frontend/app/pods/components/alert-details/component.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
index 1989da3..4cff2c6 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/alert-details/component.js
@@ -236,7 +236,7 @@ export default Component.extend({
granularity,
dimensionExploration
} = this.getProperties('isPreviewMode', 'granularity', 'dimensionExploration');
- return (isPreviewMode || (!dimensionExploration && (granularity || '').includes('DAYS')));
+ return (isPreviewMode || (!dimensionExploration && ((granularity || '').includes('MINUTES') || (granularity || '').includes('DAYS'))));
}
),
@@ -889,7 +889,7 @@ export default Component.extend({
duration: (timeWindowSize === 172800000) ? '48h' : 'custom',
selectedDimension: 'Choose a dimension',
// For now, we will only show predicted and bounds on daily and minutely metrics with no dimensions, for the Alert Overview page
- selectedBaseline: (!dimensionExploration && (granularity || '').includes('DAYS')) ? 'predicted' : 'wo1w',
+ selectedBaseline: (!dimensionExploration && ((granularity || '').includes('MINUTES') || (granularity || '').includes('DAYS'))) ? 'predicted' : 'wo1w',
// We distinguish these because it only needs the route's info on init. After that, component manages state
metricUrnList: this.get('metricUrnListRoute'),
metricUrn: this.get('metricUrnRoute')
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org