You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/04/08 00:47:24 UTC
[jira] Created: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
----------------------------------------------------------------------------
Key: HADOOP-3202
URL: https://issues.apache.org/jira/browse/HADOOP-3202
Project: Hadoop Core
Issue Type: Improvement
Components: fs
Reporter: Tsz Wo (Nicholas), SZE
We should use FileSystem.delete(path, recursive=true) instead.
See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3202:
--------------------------------------------
Attachment: patch-3202.txt
Here is a patch deprecating FileUtil.fullyDelete(FileSystem, Path)
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616933#action_12616933 ]
Hadoop QA commented on HADOOP-3202:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12386870/patch-3202.txt
against trunk revision 679772.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 522 javac compiler warnings (more than the trunk's current 521 warnings).
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2952/console
This message is automatically generated.
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3202:
-------------------------------------------
Hadoop Flags: [Reviewed]
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3202:
--------------------------------------------
Attachment: patch-3202.txt
Fixed a javadoc warning in the earlier patch.
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3202:
--------------------------------------------
Status: Patch Available (was: Open)
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617367#action_12617367 ]
Hadoop QA commented on HADOOP-3202:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387003/patch-3202.txt
against trunk revision 679930.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2958/console
This message is automatically generated.
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3202:
--------------------------------------------
Fix Version/s: 0.19.0
Assignee: Amareshwari Sriramadasu
Hadoop Flags: (was: [Incompatible change])
Status: Patch Available (was: Open)
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3202:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Amareshwari!
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3202:
--------------------------------------------
Status: Open (was: Patch Available)
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-3202:
--------------------------------------------
Attachment: patch-3202.txt
Fixed javac warning
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586702#action_12586702 ]
Arun C Murthy commented on HADOOP-3202:
---------------------------------------
+1
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616987#action_12616987 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3202:
------------------------------------------------
+1 patch looks good. The new javac warning is about that DistCp is still using the deprecated FileUtil.fullyDelete(...). We could fix it here or later.
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3202) Deprecate
org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624779#action_12624779 ]
Hudson commented on HADOOP-3202:
--------------------------------
Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])
> Deprecate org.apache.hadoop.fs.FileUtil.fullyDelete(FileSystem fs, Path dir)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-3202
> URL: https://issues.apache.org/jira/browse/HADOOP-3202
> Project: Hadoop Core
> Issue Type: Improvement
> Components: fs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.0
>
> Attachments: patch-3202.txt, patch-3202.txt, patch-3202.txt
>
>
> We should use FileSystem.delete(path, recursive=true) instead.
> See also https://issues.apache.org/jira/browse/HADOOP-771?focusedCommentId=12586566#action_12586566
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.