You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/04/20 16:43:36 UTC
Review Request 72389: Fixed composing authorization callback path on
Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72389/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Greg Mann.
Bugs: MESOS-10120
https://issues.apache.org/jira/browse/MESOS-10120
Repository: mesos
Description
-------
Fixed composing authorization callback path on Windows.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4ae5de30273fdf39788de2c25126b3b92e271957
Diff: https://reviews.apache.org/r/72389/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72389: Fixed composing authorization callback path
on Windows.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72389/#review220375
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/src/process.cpp
Line 3845 (original), 3845-3846 (patched)
<https://reviews.apache.org/r/72389/#comment308735>
Maybe a comment here as to why we're explicit?
```
// Pass the "/" separator to avoid the windows "\" separator
// getting implicitly used on windows (we don't want that to
// happen for this http request path!)
```
- Benjamin Mahler
On April 20, 2020, 4:43 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72389/
> -----------------------------------------------------------
>
> (Updated April 20, 2020, 4:43 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Greg Mann.
>
>
> Bugs: MESOS-10120
> https://issues.apache.org/jira/browse/MESOS-10120
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed composing authorization callback path on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 4ae5de30273fdf39788de2c25126b3b92e271957
>
>
> Diff: https://reviews.apache.org/r/72389/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72389: Fixed composing authorization callback path
on Windows.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72389/
-----------------------------------------------------------
(Updated April 21, 2020, 8:16 a.m.)
Review request for mesos, Benjamin Mahler and Greg Mann.
Bugs: MESOS-10120
https://issues.apache.org/jira/browse/MESOS-10120
Repository: mesos
Description
-------
Fixed composing authorization callback path on Windows.
Diffs
-----
3rdparty/libprocess/src/process.cpp 4ae5de30273fdf39788de2c25126b3b92e271957
Diff: https://reviews.apache.org/r/72389/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko