You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by virtuald <gi...@git.apache.org> on 2014/08/13 18:06:44 UTC
[GitHub] thrift pull request: THRIFT-2665: Debug statements are unnecessary...
GitHub user virtuald opened a pull request:
https://github.com/apache/thrift/pull/189
THRIFT-2665: Debug statements are unnecessary and should be removed
https://issues.apache.org/jira/browse/THRIFT-2665
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/virtuald/thrift mainline-remove-debug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/189.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #189
----
commit 67ec7e5cfe3ada7904db1439e52f2375ac72f985
Author: Dustin Spicuzza <du...@virtualroadside.com>
Date: 2014-08-12T22:02:53Z
Debug statements are unnecessary and should be removed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2665: Debug statements are unnecessary...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/189
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: THRIFT-2665: Debug statements are unnecessary...
Posted by virtuald <gi...@git.apache.org>.
Github user virtuald commented on the pull request:
https://github.com/apache/thrift/pull/189#issuecomment-52105557
Though the CI build failed, I don't think it was due to my code change, as it was a change to the python code, and the error reported is a compiler error of some sort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---