[GitHub] srowen commented on a change in pull request #23878: [SPARK-26978][CORE] Avoid magic time constants

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23878: [SPARK-26978][CORE] Avoid magic time constants
URL: https://github.com/apache/spark/pull/23878#discussion_r259586005
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala
 ##########
 @@ -132,7 +133,7 @@ package object util extends Logging {
     val ret = f
     val endTime = System.nanoTime()
     // scalastyle:off println
-    println(s"${(endTime - startTime).toDouble / 1000000}ms")
+    println(s"${(endTime - startTime).toDouble / TimeUnit.MILLISECONDS.toNanos(1)} ms")
 
 Review comment:
   Just convert the whole difference from nanos to ms?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org