[GitHub] [spark] cloud-fan commented on a change in pull request #34631: [SPARK-37277][PYTHON][SQL] Support DayTimeIntervalType in pandas UDF and Arrow optimization

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34631:
URL: https://github.com/apache/spark/pull/34631#discussion_r751923194



##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
##########
@@ -549,21 +544,18 @@ int getInt(int rowId) {
     }
   }
 
-  private static class IntervalDayAccessor extends ArrowVectorAccessor {
+  private static class DurationAccessor extends ArrowVectorAccessor {
 
-    private final IntervalDayVector accessor;
-    private final NullableIntervalDayHolder intervalDayHolder = new NullableIntervalDayHolder();
+    private final DurationVector accessor;

Review comment:
       do we need to care about precision here? (microsecond)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org