You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Fatima Khan <fa...@gmail.com> on 2018/04/30 06:18:23 UTC

Review Request 66867: RANGER-2083 : Resctict KMS audit events to KMS related users only

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66867/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.


Bugs: RANGER-2083
    https://issues.apache.org/jira/browse/RANGER-2083


Repository: ranger


Description
-------

Only Keyadmin and KMS Auditor role users should be able to see KMS related audit logs.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a0477fb 
  security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java 5cbe47a 
  security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 4c8ed83 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 


Diff: https://reviews.apache.org/r/66867/diff/1/


Testing
-------

Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs.


Thanks,

Fatima Khan


Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66867/#review202640
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 7, 2018, 9:29 a.m., Fatima Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66867/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 9:29 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2083
>     https://issues.apache.org/jira/browse/RANGER-2083
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Only Keyadmin and KMS Auditor role users should be able to see KMS related audit logs.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java b7e045d 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 
>   security-admin/src/main/webapp/scripts/utils/XAEnums.js 6e101bf 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3da7b5 
> 
> 
> Diff: https://reviews.apache.org/r/66867/diff/2/
> 
> 
> Testing
> -------
> 
> Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>


Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

Posted by Mehul Parikh <me...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66867/#review202744
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On May 9, 2018, 7:09 a.m., Fatima Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66867/
> -----------------------------------------------------------
> 
> (Updated May 9, 2018, 7:09 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2083
>     https://issues.apache.org/jira/browse/RANGER-2083
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Only Keyadmin and KMS Auditor role users should be able to see KMS related audit logs.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java b7e045d 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 
>   security-admin/src/main/webapp/scripts/utils/XAEnums.js 6e101bf 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3da7b5 
> 
> 
> Diff: https://reviews.apache.org/r/66867/diff/3/
> 
> 
> Testing
> -------
> 
> Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>


Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

Posted by Fatima Khan <fa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66867/
-----------------------------------------------------------

(Updated May 9, 2018, 7:09 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.


Bugs: RANGER-2083
    https://issues.apache.org/jira/browse/RANGER-2083


Repository: ranger


Description
-------

Only Keyadmin and KMS Auditor role users should be able to see KMS related audit logs.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java b7e045d 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js 6e101bf 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3da7b5 


Diff: https://reviews.apache.org/r/66867/diff/3/

Changes: https://reviews.apache.org/r/66867/diff/2-3/


Testing
-------

Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs.


Thanks,

Fatima Khan


Re: Review Request 66867: RANGER-2083 : Restrict KMS audit events to KMS related users only

Posted by Fatima Khan <fa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66867/
-----------------------------------------------------------

(Updated May 7, 2018, 9:29 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Sailaja Polavarapu.


Summary (updated)
-----------------

RANGER-2083 : Restrict KMS audit events to KMS related users only 


Bugs: RANGER-2083
    https://issues.apache.org/jira/browse/RANGER-2083


Repository: ranger


Description
-------

Only Keyadmin and KMS Auditor role users should be able to see KMS related audit logs.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java b7e045d 
  security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java 7dcb074 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js 6e101bf 
  security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js b3da7b5 


Diff: https://reviews.apache.org/r/66867/diff/2/

Changes: https://reviews.apache.org/r/66867/diff/1-2/


Testing
-------

Testing done by checking that only Keyadmin and KMS Auditor role users are be able to see KMS related audit logs.


Thanks,

Fatima Khan