You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/19 03:04:27 UTC
Review Request 15664: Fixed a flaky test: SlaveRecoveryTest.ShutdownSlave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15664/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-819
https://issues.apache.org/jira/browse/MESOS-819
Repository: mesos-git
Description
-------
The removal of the sleep in command executor exposed the fact that we were not waiting for an expected resource offer call in this test.
Diffs
-----
src/tests/slave_recovery_tests.cpp 3ee7b87e1f7c9d015221db18c6af764c3e537a6c
Diff: https://reviews.apache.org/r/15664/diff/
Testing
-------
make check with 100 repetitions, this test is slow :(
Thanks,
Ben Mahler
Re: Review Request 15664: Fixed a flaky test:
SlaveRecoveryTest.ShutdownSlave.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15664/#review29095
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 19, 2013, 2:04 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15664/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2013, 2:04 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-819
> https://issues.apache.org/jira/browse/MESOS-819
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The removal of the sleep in command executor exposed the fact that we were not waiting for an expected resource offer call in this test.
>
>
> Diffs
> -----
>
> src/tests/slave_recovery_tests.cpp 3ee7b87e1f7c9d015221db18c6af764c3e537a6c
>
> Diff: https://reviews.apache.org/r/15664/diff/
>
>
> Testing
> -------
>
> make check with 100 repetitions, this test is slow :(
>
>
> Thanks,
>
> Ben Mahler
>
>