You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Nikolay Izhikov <ni...@apache.org> on 2021/06/22 14:56:49 UTC

IGNITE-14812: Statistics

Hello, Igniters.

Recently huge commit was merged [1].

Taras, Alexander, can you, please, explain what is purpose of the commit?
What feature it implemented?

Looked inside the ticket and found no explanation.
Description is "Add statistics collection and usage.»

Do we have plans to document this new feature?

Also, I see very strange license in added files [2]

```
 * Copyright 2013 Aggregate Knowledge, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
```

Is it OK to have those copyright inside ASF codebase?
Is it some kind of external dependency we adopted as part of the code?
Why do we need it?

[1] https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
[2] https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java

Re: IGNITE-14812: Statistics

Posted by Nikita Safonov <vl...@gmail.com>.
Hello Igniters,

The PR with latest documentation on SQL statistics is here:
https://github.com/apache/ignite/pull/9550

Regards,
Nikita

пн, 5 июл. 2021 г. в 12:53, Nikita Safonov <vl...@gmail.com>:

> Hello Igniters,
>
> I'd be glad to help with documenting this functionality.
> I do believe that it won't take long. Hope to finish it before the end of
> next week to have enough time for docs discussion.
>
> Regards,
> Nikita
>
> ср, 23 июн. 2021 г. в 18:11, Ivan Daschinsky <iv...@gmail.com>:
>
>> AFAIK, it is enough to include mention of this library in NOTICE, please
>> see here [1][2][3]
>>
>> [1] -- https://www.apache.org/legal/src-headers.html#3party
>> [2] -- https://www.apache.org/legal/src-headers.html#notice
>> [3] -- https://www.apache.org/legal/resolved.html
>>
>> ср, 23 июн. 2021 г. в 17:36, Valentin Kulichenko <
>> valentin.kulichenko@gmail.com>:
>>
>> > Taras,
>> >
>> > It is true that we try to minimize dependencies, but there are some
>> anyway.
>> > I think it's perfectly fine to add this library as a dependency.
>> >
>> > Will you be able to do this asap? It is surely better than reverting the
>> > commit :)
>> >
>> > -Val
>> >
>> > On Wed, Jun 23, 2021 at 12:32 AM Taras Ledkov <tl...@gridgain.com>
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > >  > Taras, can you, please, describe the features that was implemented
>> in
>> > > this merge?
>> > >  > How users supposed to use them?
>> > >  > Do we have plans to document?
>> > >
>> > > Sure. Alexander Belyak will describe and file ticket to documentation.
>> > >
>> > > On 23.06.2021 9:27, Nikolay Izhikov wrote:
>> > > > Hello, Taras.
>> > > >
>> > > > Thanks for feedback.
>> > > >
>> > > >> AFAIK and as long as I can remember Ignite project try to minimize
>> > > external dependencies usage and adds new external dependency only when
>> > > there is no other way out.
>> > > > Does it mean we have to incapsulate every external library we want
>> to
>> > > use?
>> > > >
>> > > > Taras, can you, please, describe the features that was implemented
>> in
>> > > this merge?
>> > > > How users supposed to use them?
>> > > > Do we have plans to document?
>> > > >
>> > > >
>> > > >> 23 июня 2021 г., в 09:21, Taras Ledkov <tl...@gridgain.com>
>> > > написал(а):
>> > > >>
>> > > >> Hi,
>> > > >>
>> > > >> We have discussed BCrypt include/add dependency here [1].
>> > > >> AFAIK and as long as I can remember Ignite project try to minimize
>> > > external dependencies usage
>> > > >> and adds new external dependency only when there is no other way
>> out.
>> > > >>
>> > > >> [1].
>> > >
>> >
>> http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html
>> > > >>
>> > > >> On 23.06.2021 3:08, Valentin Kulichenko wrote:
>> > > >>> Dmitry,
>> > > >>>
>> > > >>> As the PMC chair, would you mind contacting legal regarding the
>> > matter?
>> > > >>> This is not the only example of such code (e.g. [1]), so we should
>> > look
>> > > >>> into this asap.
>> > > >>>
>> > > >>> [1]
>> > > >>>
>> > >
>> >
>> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
>> > > >>>
>> > > >>> As for this particular commit, can HLL be added as a dependency
>> > > instead? Is
>> > > >>> there any particular reason to include the source code? @Sasha
>> Belyak
>> > > >>> <rt...@gmail.com> , can you please chime in?
>> > > >>>
>> > > >>> -Val
>> > > >>>
>> > > >>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dpavlov@apache.org
>> >
>> > > wrote:
>> > > >>>
>> > > >>>> Hi Nikolai,
>> > > >>>>
>> > > >>>> thank you for noticing. I guess it's not about license, but about
>> > > >>>> Intellectual Property (IP) ownership.
>> > > >>>>
>> > > >>>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely
>> allowed
>> > to
>> > > be
>> > > >>>> used in the codebase for an Apache project (
>> > > >>>> https://www.apache.org/legal/resolved.html)
>> > > >>>>
>> > > >>>> But licenese and IP owner are 2 sligthly different things. E.g at
>> > the
>> > > end
>> > > >>>> of any website you can find:
>> > > >>>> Copyright © 2021 The Apache Software Foundation, Licensed under
>> the
>> > > Apache
>> > > >>>> License, Version 2.0.
>> > > >>>>
>> > > >>>> Incubated projects are mandated to transfer IP to the ASF. And
>> I'm
>> > not
>> > > >>>> aware of any exceptions.
>> > > >>>>
>> > > >>>> In this PR there are 5 classes which licenses with AL 2.0, but IP
>> > > owner is
>> > > >>>> 3rd party company.
>> > > >>>>
>> > > >>>> I'm a bit concerned about having such code in the project. I'd
>> > rather
>> > > >>>> reverted it until we have approval from experts at mailing list:
>> > > >>>> legal-discuss@apache.org
>> > > >>>>
>> > > >>>> Sincerely,
>> > > >>>> Dmitriy Pavlov
>> > > >>>>
>> > > >>>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org>
>> > wrote:
>> > > >>>>> Hello, Igniters.
>> > > >>>>>
>> > > >>>>> Recently huge commit was merged [1].
>> > > >>>>>
>> > > >>>>> Taras, Alexander, can you, please, explain what is purpose of
>> the
>> > > commit?
>> > > >>>>> What feature it implemented?
>> > > >>>>>
>> > > >>>>> Looked inside the ticket and found no explanation.
>> > > >>>>> Description is "Add statistics collection and usage.»
>> > > >>>>>
>> > > >>>>> Do we have plans to document this new feature?
>> > > >>>>>
>> > > >>>>> Also, I see very strange license in added files [2]
>> > > >>>>>
>> > > >>>>> ```
>> > > >>>>>   * Copyright 2013 Aggregate Knowledge, Inc.
>> > > >>>>>   *
>> > > >>>>>   * Licensed under the Apache License, Version 2.0 (the
>> "License");
>> > > >>>>> ```
>> > > >>>>>
>> > > >>>>> Is it OK to have those copyright inside ASF codebase?
>> > > >>>>> Is it some kind of external dependency we adopted as part of the
>> > > code?
>> > > >>>>> Why do we need it?
>> > > >>>>>
>> > > >>>>> [1]
>> > > >>>>
>> > >
>> >
>> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
>> > > >>>>> [2]
>> > > >>>>
>> > >
>> >
>> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
>> > > >>>>
>> > > >> --
>> > > >> Taras Ledkov
>> > > >> Mail-To: tledkov@gridgain.com
>> > > >>
>> > > --
>> > > Taras Ledkov
>> > > Mail-To: tledkov@gridgain.com
>> > >
>> > >
>> >
>>
>>
>> --
>> Sincerely yours, Ivan Daschinskiy
>>
>

Re: IGNITE-14812: Statistics

Posted by Nikita Safonov <vl...@gmail.com>.
Hello Igniters,

I'd be glad to help with documenting this functionality.
I do believe that it won't take long. Hope to finish it before the end of
next week to have enough time for docs discussion.

Regards,
Nikita

ср, 23 июн. 2021 г. в 18:11, Ivan Daschinsky <iv...@gmail.com>:

> AFAIK, it is enough to include mention of this library in NOTICE, please
> see here [1][2][3]
>
> [1] -- https://www.apache.org/legal/src-headers.html#3party
> [2] -- https://www.apache.org/legal/src-headers.html#notice
> [3] -- https://www.apache.org/legal/resolved.html
>
> ср, 23 июн. 2021 г. в 17:36, Valentin Kulichenko <
> valentin.kulichenko@gmail.com>:
>
> > Taras,
> >
> > It is true that we try to minimize dependencies, but there are some
> anyway.
> > I think it's perfectly fine to add this library as a dependency.
> >
> > Will you be able to do this asap? It is surely better than reverting the
> > commit :)
> >
> > -Val
> >
> > On Wed, Jun 23, 2021 at 12:32 AM Taras Ledkov <tl...@gridgain.com>
> > wrote:
> >
> > > Hi,
> > >
> > >  > Taras, can you, please, describe the features that was implemented
> in
> > > this merge?
> > >  > How users supposed to use them?
> > >  > Do we have plans to document?
> > >
> > > Sure. Alexander Belyak will describe and file ticket to documentation.
> > >
> > > On 23.06.2021 9:27, Nikolay Izhikov wrote:
> > > > Hello, Taras.
> > > >
> > > > Thanks for feedback.
> > > >
> > > >> AFAIK and as long as I can remember Ignite project try to minimize
> > > external dependencies usage and adds new external dependency only when
> > > there is no other way out.
> > > > Does it mean we have to incapsulate every external library we want to
> > > use?
> > > >
> > > > Taras, can you, please, describe the features that was implemented in
> > > this merge?
> > > > How users supposed to use them?
> > > > Do we have plans to document?
> > > >
> > > >
> > > >> 23 июня 2021 г., в 09:21, Taras Ledkov <tl...@gridgain.com>
> > > написал(а):
> > > >>
> > > >> Hi,
> > > >>
> > > >> We have discussed BCrypt include/add dependency here [1].
> > > >> AFAIK and as long as I can remember Ignite project try to minimize
> > > external dependencies usage
> > > >> and adds new external dependency only when there is no other way
> out.
> > > >>
> > > >> [1].
> > >
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html
> > > >>
> > > >> On 23.06.2021 3:08, Valentin Kulichenko wrote:
> > > >>> Dmitry,
> > > >>>
> > > >>> As the PMC chair, would you mind contacting legal regarding the
> > matter?
> > > >>> This is not the only example of such code (e.g. [1]), so we should
> > look
> > > >>> into this asap.
> > > >>>
> > > >>> [1]
> > > >>>
> > >
> >
> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
> > > >>>
> > > >>> As for this particular commit, can HLL be added as a dependency
> > > instead? Is
> > > >>> there any particular reason to include the source code? @Sasha
> Belyak
> > > >>> <rt...@gmail.com> , can you please chime in?
> > > >>>
> > > >>> -Val
> > > >>>
> > > >>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org>
> > > wrote:
> > > >>>
> > > >>>> Hi Nikolai,
> > > >>>>
> > > >>>> thank you for noticing. I guess it's not about license, but about
> > > >>>> Intellectual Property (IP) ownership.
> > > >>>>
> > > >>>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed
> > to
> > > be
> > > >>>> used in the codebase for an Apache project (
> > > >>>> https://www.apache.org/legal/resolved.html)
> > > >>>>
> > > >>>> But licenese and IP owner are 2 sligthly different things. E.g at
> > the
> > > end
> > > >>>> of any website you can find:
> > > >>>> Copyright © 2021 The Apache Software Foundation, Licensed under
> the
> > > Apache
> > > >>>> License, Version 2.0.
> > > >>>>
> > > >>>> Incubated projects are mandated to transfer IP to the ASF. And I'm
> > not
> > > >>>> aware of any exceptions.
> > > >>>>
> > > >>>> In this PR there are 5 classes which licenses with AL 2.0, but IP
> > > owner is
> > > >>>> 3rd party company.
> > > >>>>
> > > >>>> I'm a bit concerned about having such code in the project. I'd
> > rather
> > > >>>> reverted it until we have approval from experts at mailing list:
> > > >>>> legal-discuss@apache.org
> > > >>>>
> > > >>>> Sincerely,
> > > >>>> Dmitriy Pavlov
> > > >>>>
> > > >>>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org>
> > wrote:
> > > >>>>> Hello, Igniters.
> > > >>>>>
> > > >>>>> Recently huge commit was merged [1].
> > > >>>>>
> > > >>>>> Taras, Alexander, can you, please, explain what is purpose of the
> > > commit?
> > > >>>>> What feature it implemented?
> > > >>>>>
> > > >>>>> Looked inside the ticket and found no explanation.
> > > >>>>> Description is "Add statistics collection and usage.»
> > > >>>>>
> > > >>>>> Do we have plans to document this new feature?
> > > >>>>>
> > > >>>>> Also, I see very strange license in added files [2]
> > > >>>>>
> > > >>>>> ```
> > > >>>>>   * Copyright 2013 Aggregate Knowledge, Inc.
> > > >>>>>   *
> > > >>>>>   * Licensed under the Apache License, Version 2.0 (the
> "License");
> > > >>>>> ```
> > > >>>>>
> > > >>>>> Is it OK to have those copyright inside ASF codebase?
> > > >>>>> Is it some kind of external dependency we adopted as part of the
> > > code?
> > > >>>>> Why do we need it?
> > > >>>>>
> > > >>>>> [1]
> > > >>>>
> > >
> >
> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
> > > >>>>> [2]
> > > >>>>
> > >
> >
> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
> > > >>>>
> > > >> --
> > > >> Taras Ledkov
> > > >> Mail-To: tledkov@gridgain.com
> > > >>
> > > --
> > > Taras Ledkov
> > > Mail-To: tledkov@gridgain.com
> > >
> > >
> >
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>

Re: IGNITE-14812: Statistics

Posted by Ivan Daschinsky <iv...@gmail.com>.
AFAIK, it is enough to include mention of this library in NOTICE, please
see here [1][2][3]

[1] -- https://www.apache.org/legal/src-headers.html#3party
[2] -- https://www.apache.org/legal/src-headers.html#notice
[3] -- https://www.apache.org/legal/resolved.html

ср, 23 июн. 2021 г. в 17:36, Valentin Kulichenko <
valentin.kulichenko@gmail.com>:

> Taras,
>
> It is true that we try to minimize dependencies, but there are some anyway.
> I think it's perfectly fine to add this library as a dependency.
>
> Will you be able to do this asap? It is surely better than reverting the
> commit :)
>
> -Val
>
> On Wed, Jun 23, 2021 at 12:32 AM Taras Ledkov <tl...@gridgain.com>
> wrote:
>
> > Hi,
> >
> >  > Taras, can you, please, describe the features that was implemented in
> > this merge?
> >  > How users supposed to use them?
> >  > Do we have plans to document?
> >
> > Sure. Alexander Belyak will describe and file ticket to documentation.
> >
> > On 23.06.2021 9:27, Nikolay Izhikov wrote:
> > > Hello, Taras.
> > >
> > > Thanks for feedback.
> > >
> > >> AFAIK and as long as I can remember Ignite project try to minimize
> > external dependencies usage and adds new external dependency only when
> > there is no other way out.
> > > Does it mean we have to incapsulate every external library we want to
> > use?
> > >
> > > Taras, can you, please, describe the features that was implemented in
> > this merge?
> > > How users supposed to use them?
> > > Do we have plans to document?
> > >
> > >
> > >> 23 июня 2021 г., в 09:21, Taras Ledkov <tl...@gridgain.com>
> > написал(а):
> > >>
> > >> Hi,
> > >>
> > >> We have discussed BCrypt include/add dependency here [1].
> > >> AFAIK and as long as I can remember Ignite project try to minimize
> > external dependencies usage
> > >> and adds new external dependency only when there is no other way out.
> > >>
> > >> [1].
> >
> http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html
> > >>
> > >> On 23.06.2021 3:08, Valentin Kulichenko wrote:
> > >>> Dmitry,
> > >>>
> > >>> As the PMC chair, would you mind contacting legal regarding the
> matter?
> > >>> This is not the only example of such code (e.g. [1]), so we should
> look
> > >>> into this asap.
> > >>>
> > >>> [1]
> > >>>
> >
> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
> > >>>
> > >>> As for this particular commit, can HLL be added as a dependency
> > instead? Is
> > >>> there any particular reason to include the source code? @Sasha Belyak
> > >>> <rt...@gmail.com> , can you please chime in?
> > >>>
> > >>> -Val
> > >>>
> > >>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org>
> > wrote:
> > >>>
> > >>>> Hi Nikolai,
> > >>>>
> > >>>> thank you for noticing. I guess it's not about license, but about
> > >>>> Intellectual Property (IP) ownership.
> > >>>>
> > >>>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed
> to
> > be
> > >>>> used in the codebase for an Apache project (
> > >>>> https://www.apache.org/legal/resolved.html)
> > >>>>
> > >>>> But licenese and IP owner are 2 sligthly different things. E.g at
> the
> > end
> > >>>> of any website you can find:
> > >>>> Copyright © 2021 The Apache Software Foundation, Licensed under the
> > Apache
> > >>>> License, Version 2.0.
> > >>>>
> > >>>> Incubated projects are mandated to transfer IP to the ASF. And I'm
> not
> > >>>> aware of any exceptions.
> > >>>>
> > >>>> In this PR there are 5 classes which licenses with AL 2.0, but IP
> > owner is
> > >>>> 3rd party company.
> > >>>>
> > >>>> I'm a bit concerned about having such code in the project. I'd
> rather
> > >>>> reverted it until we have approval from experts at mailing list:
> > >>>> legal-discuss@apache.org
> > >>>>
> > >>>> Sincerely,
> > >>>> Dmitriy Pavlov
> > >>>>
> > >>>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org>
> wrote:
> > >>>>> Hello, Igniters.
> > >>>>>
> > >>>>> Recently huge commit was merged [1].
> > >>>>>
> > >>>>> Taras, Alexander, can you, please, explain what is purpose of the
> > commit?
> > >>>>> What feature it implemented?
> > >>>>>
> > >>>>> Looked inside the ticket and found no explanation.
> > >>>>> Description is "Add statistics collection and usage.»
> > >>>>>
> > >>>>> Do we have plans to document this new feature?
> > >>>>>
> > >>>>> Also, I see very strange license in added files [2]
> > >>>>>
> > >>>>> ```
> > >>>>>   * Copyright 2013 Aggregate Knowledge, Inc.
> > >>>>>   *
> > >>>>>   * Licensed under the Apache License, Version 2.0 (the "License");
> > >>>>> ```
> > >>>>>
> > >>>>> Is it OK to have those copyright inside ASF codebase?
> > >>>>> Is it some kind of external dependency we adopted as part of the
> > code?
> > >>>>> Why do we need it?
> > >>>>>
> > >>>>> [1]
> > >>>>
> >
> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
> > >>>>> [2]
> > >>>>
> >
> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
> > >>>>
> > >> --
> > >> Taras Ledkov
> > >> Mail-To: tledkov@gridgain.com
> > >>
> > --
> > Taras Ledkov
> > Mail-To: tledkov@gridgain.com
> >
> >
>


-- 
Sincerely yours, Ivan Daschinskiy

Re: IGNITE-14812: Statistics

Posted by Valentin Kulichenko <va...@gmail.com>.
Taras,

It is true that we try to minimize dependencies, but there are some anyway.
I think it's perfectly fine to add this library as a dependency.

Will you be able to do this asap? It is surely better than reverting the
commit :)

-Val

On Wed, Jun 23, 2021 at 12:32 AM Taras Ledkov <tl...@gridgain.com> wrote:

> Hi,
>
>  > Taras, can you, please, describe the features that was implemented in
> this merge?
>  > How users supposed to use them?
>  > Do we have plans to document?
>
> Sure. Alexander Belyak will describe and file ticket to documentation.
>
> On 23.06.2021 9:27, Nikolay Izhikov wrote:
> > Hello, Taras.
> >
> > Thanks for feedback.
> >
> >> AFAIK and as long as I can remember Ignite project try to minimize
> external dependencies usage and adds new external dependency only when
> there is no other way out.
> > Does it mean we have to incapsulate every external library we want to
> use?
> >
> > Taras, can you, please, describe the features that was implemented in
> this merge?
> > How users supposed to use them?
> > Do we have plans to document?
> >
> >
> >> 23 июня 2021 г., в 09:21, Taras Ledkov <tl...@gridgain.com>
> написал(а):
> >>
> >> Hi,
> >>
> >> We have discussed BCrypt include/add dependency here [1].
> >> AFAIK and as long as I can remember Ignite project try to minimize
> external dependencies usage
> >> and adds new external dependency only when there is no other way out.
> >>
> >> [1].
> http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html
> >>
> >> On 23.06.2021 3:08, Valentin Kulichenko wrote:
> >>> Dmitry,
> >>>
> >>> As the PMC chair, would you mind contacting legal regarding the matter?
> >>> This is not the only example of such code (e.g. [1]), so we should look
> >>> into this asap.
> >>>
> >>> [1]
> >>>
> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
> >>>
> >>> As for this particular commit, can HLL be added as a dependency
> instead? Is
> >>> there any particular reason to include the source code? @Sasha Belyak
> >>> <rt...@gmail.com> , can you please chime in?
> >>>
> >>> -Val
> >>>
> >>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org>
> wrote:
> >>>
> >>>> Hi Nikolai,
> >>>>
> >>>> thank you for noticing. I guess it's not about license, but about
> >>>> Intellectual Property (IP) ownership.
> >>>>
> >>>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to
> be
> >>>> used in the codebase for an Apache project (
> >>>> https://www.apache.org/legal/resolved.html)
> >>>>
> >>>> But licenese and IP owner are 2 sligthly different things. E.g at the
> end
> >>>> of any website you can find:
> >>>> Copyright © 2021 The Apache Software Foundation, Licensed under the
> Apache
> >>>> License, Version 2.0.
> >>>>
> >>>> Incubated projects are mandated to transfer IP to the ASF. And I'm not
> >>>> aware of any exceptions.
> >>>>
> >>>> In this PR there are 5 classes which licenses with AL 2.0, but IP
> owner is
> >>>> 3rd party company.
> >>>>
> >>>> I'm a bit concerned about having such code in the project. I'd rather
> >>>> reverted it until we have approval from experts at mailing list:
> >>>> legal-discuss@apache.org
> >>>>
> >>>> Sincerely,
> >>>> Dmitriy Pavlov
> >>>>
> >>>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org> wrote:
> >>>>> Hello, Igniters.
> >>>>>
> >>>>> Recently huge commit was merged [1].
> >>>>>
> >>>>> Taras, Alexander, can you, please, explain what is purpose of the
> commit?
> >>>>> What feature it implemented?
> >>>>>
> >>>>> Looked inside the ticket and found no explanation.
> >>>>> Description is "Add statistics collection and usage.»
> >>>>>
> >>>>> Do we have plans to document this new feature?
> >>>>>
> >>>>> Also, I see very strange license in added files [2]
> >>>>>
> >>>>> ```
> >>>>>   * Copyright 2013 Aggregate Knowledge, Inc.
> >>>>>   *
> >>>>>   * Licensed under the Apache License, Version 2.0 (the "License");
> >>>>> ```
> >>>>>
> >>>>> Is it OK to have those copyright inside ASF codebase?
> >>>>> Is it some kind of external dependency we adopted as part of the
> code?
> >>>>> Why do we need it?
> >>>>>
> >>>>> [1]
> >>>>
> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
> >>>>> [2]
> >>>>
> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
> >>>>
> >> --
> >> Taras Ledkov
> >> Mail-To: tledkov@gridgain.com
> >>
> --
> Taras Ledkov
> Mail-To: tledkov@gridgain.com
>
>

Re: IGNITE-14812: Statistics

Posted by Taras Ledkov <tl...@gridgain.com>.
Hi,

 > Taras, can you, please, describe the features that was implemented in 
this merge?
 > How users supposed to use them?
 > Do we have plans to document?

Sure. Alexander Belyak will describe and file ticket to documentation.

On 23.06.2021 9:27, Nikolay Izhikov wrote:
> Hello, Taras.
>
> Thanks for feedback.
>
>> AFAIK and as long as I can remember Ignite project try to minimize external dependencies usage and adds new external dependency only when there is no other way out.
> Does it mean we have to incapsulate every external library we want to use?
>
> Taras, can you, please, describe the features that was implemented in this merge?
> How users supposed to use them?
> Do we have plans to document?
>
>
>> 23 июня 2021 г., в 09:21, Taras Ledkov <tl...@gridgain.com> написал(а):
>>
>> Hi,
>>
>> We have discussed BCrypt include/add dependency here [1].
>> AFAIK and as long as I can remember Ignite project try to minimize external dependencies usage
>> and adds new external dependency only when there is no other way out.
>>
>> [1]. http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html
>>
>> On 23.06.2021 3:08, Valentin Kulichenko wrote:
>>> Dmitry,
>>>
>>> As the PMC chair, would you mind contacting legal regarding the matter?
>>> This is not the only example of such code (e.g. [1]), so we should look
>>> into this asap.
>>>
>>> [1]
>>> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
>>>
>>> As for this particular commit, can HLL be added as a dependency instead? Is
>>> there any particular reason to include the source code? @Sasha Belyak
>>> <rt...@gmail.com> , can you please chime in?
>>>
>>> -Val
>>>
>>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org> wrote:
>>>
>>>> Hi Nikolai,
>>>>
>>>> thank you for noticing. I guess it's not about license, but about
>>>> Intellectual Property (IP) ownership.
>>>>
>>>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be
>>>> used in the codebase for an Apache project (
>>>> https://www.apache.org/legal/resolved.html)
>>>>
>>>> But licenese and IP owner are 2 sligthly different things. E.g at the end
>>>> of any website you can find:
>>>> Copyright © 2021 The Apache Software Foundation, Licensed under the Apache
>>>> License, Version 2.0.
>>>>
>>>> Incubated projects are mandated to transfer IP to the ASF. And I'm not
>>>> aware of any exceptions.
>>>>
>>>> In this PR there are 5 classes which licenses with AL 2.0, but IP owner is
>>>> 3rd party company.
>>>>
>>>> I'm a bit concerned about having such code in the project. I'd rather
>>>> reverted it until we have approval from experts at mailing list:
>>>> legal-discuss@apache.org
>>>>
>>>> Sincerely,
>>>> Dmitriy Pavlov
>>>>
>>>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org> wrote:
>>>>> Hello, Igniters.
>>>>>
>>>>> Recently huge commit was merged [1].
>>>>>
>>>>> Taras, Alexander, can you, please, explain what is purpose of the commit?
>>>>> What feature it implemented?
>>>>>
>>>>> Looked inside the ticket and found no explanation.
>>>>> Description is "Add statistics collection and usage.»
>>>>>
>>>>> Do we have plans to document this new feature?
>>>>>
>>>>> Also, I see very strange license in added files [2]
>>>>>
>>>>> ```
>>>>>   * Copyright 2013 Aggregate Knowledge, Inc.
>>>>>   *
>>>>>   * Licensed under the Apache License, Version 2.0 (the "License");
>>>>> ```
>>>>>
>>>>> Is it OK to have those copyright inside ASF codebase?
>>>>> Is it some kind of external dependency we adopted as part of the code?
>>>>> Why do we need it?
>>>>>
>>>>> [1]
>>>> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
>>>>> [2]
>>>> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
>>>>
>> -- 
>> Taras Ledkov
>> Mail-To: tledkov@gridgain.com
>>
-- 
Taras Ledkov
Mail-To: tledkov@gridgain.com

Re: IGNITE-14812: Statistics

Posted by Nikolay Izhikov <ni...@apache.org>.
Hello, Taras.

Thanks for feedback.

> AFAIK and as long as I can remember Ignite project try to minimize external dependencies usage and adds new external dependency only when there is no other way out.

Does it mean we have to incapsulate every external library we want to use?

Taras, can you, please, describe the features that was implemented in this merge?
How users supposed to use them?
Do we have plans to document?


> 23 июня 2021 г., в 09:21, Taras Ledkov <tl...@gridgain.com> написал(а):
> 
> Hi,
> 
> We have discussed BCrypt include/add dependency here [1].
> AFAIK and as long as I can remember Ignite project try to minimize external dependencies usage
> and adds new external dependency only when there is no other way out.
> 
> [1]. http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html
> 
> On 23.06.2021 3:08, Valentin Kulichenko wrote:
>> Dmitry,
>> 
>> As the PMC chair, would you mind contacting legal regarding the matter?
>> This is not the only example of such code (e.g. [1]), so we should look
>> into this asap.
>> 
>> [1]
>> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
>> 
>> As for this particular commit, can HLL be added as a dependency instead? Is
>> there any particular reason to include the source code? @Sasha Belyak
>> <rt...@gmail.com> , can you please chime in?
>> 
>> -Val
>> 
>> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org> wrote:
>> 
>>> Hi Nikolai,
>>> 
>>> thank you for noticing. I guess it's not about license, but about
>>> Intellectual Property (IP) ownership.
>>> 
>>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be
>>> used in the codebase for an Apache project (
>>> https://www.apache.org/legal/resolved.html)
>>> 
>>> But licenese and IP owner are 2 sligthly different things. E.g at the end
>>> of any website you can find:
>>> Copyright © 2021 The Apache Software Foundation, Licensed under the Apache
>>> License, Version 2.0.
>>> 
>>> Incubated projects are mandated to transfer IP to the ASF. And I'm not
>>> aware of any exceptions.
>>> 
>>> In this PR there are 5 classes which licenses with AL 2.0, but IP owner is
>>> 3rd party company.
>>> 
>>> I'm a bit concerned about having such code in the project. I'd rather
>>> reverted it until we have approval from experts at mailing list:
>>> legal-discuss@apache.org
>>> 
>>> Sincerely,
>>> Dmitriy Pavlov
>>> 
>>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org> wrote:
>>>> Hello, Igniters.
>>>> 
>>>> Recently huge commit was merged [1].
>>>> 
>>>> Taras, Alexander, can you, please, explain what is purpose of the commit?
>>>> What feature it implemented?
>>>> 
>>>> Looked inside the ticket and found no explanation.
>>>> Description is "Add statistics collection and usage.»
>>>> 
>>>> Do we have plans to document this new feature?
>>>> 
>>>> Also, I see very strange license in added files [2]
>>>> 
>>>> ```
>>>>  * Copyright 2013 Aggregate Knowledge, Inc.
>>>>  *
>>>>  * Licensed under the Apache License, Version 2.0 (the "License");
>>>> ```
>>>> 
>>>> Is it OK to have those copyright inside ASF codebase?
>>>> Is it some kind of external dependency we adopted as part of the code?
>>>> Why do we need it?
>>>> 
>>>> [1]
>>> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
>>>> [2]
>>> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
>>> 
> -- 
> Taras Ledkov
> Mail-To: tledkov@gridgain.com
>

Re: IGNITE-14812: Statistics

Posted by Taras Ledkov <tl...@gridgain.com>.
Hi,

We have discussed BCrypt include/add dependency here [1].
AFAIK and as long as I can remember Ignite project try to minimize 
external dependencies usage
and adds new external dependency only when there is no other way out.

[1]. 
http://apache-ignite-developers.2346864.n4.nabble.com/Username-password-authentication-for-thin-clients-tp26058p26954.html

On 23.06.2021 3:08, Valentin Kulichenko wrote:
> Dmitry,
>
> As the PMC chair, would you mind contacting legal regarding the matter?
> This is not the only example of such code (e.g. [1]), so we should look
> into this asap.
>
> [1]
> https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java
>
> As for this particular commit, can HLL be added as a dependency instead? Is
> there any particular reason to include the source code? @Sasha Belyak
> <rt...@gmail.com> , can you please chime in?
>
> -Val
>
> On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org> wrote:
>
>> Hi Nikolai,
>>
>> thank you for noticing. I guess it's not about license, but about
>> Intellectual Property (IP) ownership.
>>
>> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be
>> used in the codebase for an Apache project (
>> https://www.apache.org/legal/resolved.html)
>>
>> But licenese and IP owner are 2 sligthly different things. E.g at the end
>> of any website you can find:
>> Copyright © 2021 The Apache Software Foundation, Licensed under the Apache
>> License, Version 2.0.
>>
>> Incubated projects are mandated to transfer IP to the ASF. And I'm not
>> aware of any exceptions.
>>
>> In this PR there are 5 classes which licenses with AL 2.0, but IP owner is
>> 3rd party company.
>>
>> I'm a bit concerned about having such code in the project. I'd rather
>> reverted it until we have approval from experts at mailing list:
>> legal-discuss@apache.org
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org> wrote:
>>> Hello, Igniters.
>>>
>>> Recently huge commit was merged [1].
>>>
>>> Taras, Alexander, can you, please, explain what is purpose of the commit?
>>> What feature it implemented?
>>>
>>> Looked inside the ticket and found no explanation.
>>> Description is "Add statistics collection and usage.»
>>>
>>> Do we have plans to document this new feature?
>>>
>>> Also, I see very strange license in added files [2]
>>>
>>> ```
>>>   * Copyright 2013 Aggregate Knowledge, Inc.
>>>   *
>>>   * Licensed under the Apache License, Version 2.0 (the "License");
>>> ```
>>>
>>> Is it OK to have those copyright inside ASF codebase?
>>> Is it some kind of external dependency we adopted as part of the code?
>>> Why do we need it?
>>>
>>> [1]
>> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
>>> [2]
>> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
>>
-- 
Taras Ledkov
Mail-To: tledkov@gridgain.com

Re: IGNITE-14812: Statistics

Posted by Valentin Kulichenko <va...@gmail.com>.
Dmitry,

As the PMC chair, would you mind contacting legal regarding the matter?
This is not the only example of such code (e.g. [1]), so we should look
into this asap.

[1]
https://github.com/apache/ignite/blob/master/modules/core/src/main/java/org/mindrot/BCrypt.java

As for this particular commit, can HLL be added as a dependency instead? Is
there any particular reason to include the source code? @Sasha Belyak
<rt...@gmail.com> , can you please chime in?

-Val

On Tue, Jun 22, 2021 at 8:10 AM Dmitry Pavlov <dp...@apache.org> wrote:

> Hi Nikolai,
>
> thank you for noticing. I guess it's not about license, but about
> Intellectual Property (IP) ownership.
>
> AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be
> used in the codebase for an Apache project (
> https://www.apache.org/legal/resolved.html)
>
> But licenese and IP owner are 2 sligthly different things. E.g at the end
> of any website you can find:
> Copyright © 2021 The Apache Software Foundation, Licensed under the Apache
> License, Version 2.0.
>
> Incubated projects are mandated to transfer IP to the ASF. And I'm not
> aware of any exceptions.
>
> In this PR there are 5 classes which licenses with AL 2.0, but IP owner is
> 3rd party company.
>
> I'm a bit concerned about having such code in the project. I'd rather
> reverted it until we have approval from experts at mailing list:
> legal-discuss@apache.org
>
> Sincerely,
> Dmitriy Pavlov
>
> On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org> wrote:
> > Hello, Igniters.
> >
> > Recently huge commit was merged [1].
> >
> > Taras, Alexander, can you, please, explain what is purpose of the commit?
> > What feature it implemented?
> >
> > Looked inside the ticket and found no explanation.
> > Description is "Add statistics collection and usage.»
> >
> > Do we have plans to document this new feature?
> >
> > Also, I see very strange license in added files [2]
> >
> > ```
> >  * Copyright 2013 Aggregate Knowledge, Inc.
> >  *
> >  * Licensed under the Apache License, Version 2.0 (the "License");
> > ```
> >
> > Is it OK to have those copyright inside ASF codebase?
> > Is it some kind of external dependency we adopted as part of the code?
> > Why do we need it?
> >
> > [1]
> https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
> > [2]
> https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java
>

Re: IGNITE-14812: Statistics

Posted by Dmitry Pavlov <dp...@apache.org>.
Hi Nikolai,

thank you for noticing. I guess it's not about license, but about Intellectual Property (IP) ownership.

AFAIK, Apache License 2.0 is here and AL 2.0 is definetely allowed to be used in the codebase for an Apache project (https://www.apache.org/legal/resolved.html)

But licenese and IP owner are 2 sligthly different things. E.g at the end of any website you can find:
Copyright © 2021 The Apache Software Foundation, Licensed under the Apache License, Version 2.0.

Incubated projects are mandated to transfer IP to the ASF. And I'm not aware of any exceptions. 

In this PR there are 5 classes which licenses with AL 2.0, but IP owner is 3rd party company. 

I'm a bit concerned about having such code in the project. I'd rather reverted it until we have approval from experts at mailing list: legal-discuss@apache.org 

Sincerely,
Dmitriy Pavlov

On 2021/06/22 14:56:49, Nikolay Izhikov <ni...@apache.org> wrote: 
> Hello, Igniters.
> 
> Recently huge commit was merged [1].
> 
> Taras, Alexander, can you, please, explain what is purpose of the commit?
> What feature it implemented?
> 
> Looked inside the ticket and found no explanation.
> Description is "Add statistics collection and usage.»
> 
> Do we have plans to document this new feature?
> 
> Also, I see very strange license in added files [2]
> 
> ```
>  * Copyright 2013 Aggregate Knowledge, Inc.
>  *
>  * Licensed under the Apache License, Version 2.0 (the "License");
> ```
> 
> Is it OK to have those copyright inside ASF codebase?
> Is it some kind of external dependency we adopted as part of the code?
> Why do we need it?
> 
> [1] https://github.com/apache/ignite/commit/503a98495433e1d0cf84f8be8c1e2adc57034fbb
> [2] https://github.com/apache/ignite/blob/master/modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/IHLLMetadata.java