[kudu-CR] KUDU-2212 mute TSAN on destruction of a locked mutex in glog

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Hello Kudu Jenkins, Andrew Wong, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13763

to look at the new patch set (#2).

Change subject: KUDU-2212 mute TSAN on destruction of a locked mutex in glog
......................................................................

KUDU-2212 mute TSAN on destruction of a locked mutex in glog

This patch adds a suppression for TSAN warning about destruction
of a locked mutex in libglog.  Since the only registered instances
of the issue happen only during shutdown of the C++ runtime upon exit
of kudu CLI process, it seems safe to mute it for a while.  In addition,
I added a suppression for a warning about possible deadlock while
shutting down libglog's runtime.

The motivation for this change is to hunt down another issue tracked
by KUDU-2878: while doing so, this benign TSAN warning hinders the
scenario used to RCA the latter.

The suppression of the warnings for a locked mutex relies on the fix for
issue 944 in the thread sanitizers. The fix is back-ported as a patch
for LLVM 6.0 in Kudu's thirdparty.  For details on the TSAN suppressions
fix, see https://github.com/google/sanitizers/issues/944.

The results of two representative 1K runs are below: kudu-admin-test built
in TSAN with --gtest_filter='*ToolTest.TestDeleteTable*' before and after
the fix.

  before 2 out of 1K failed:
    http://dist-test.cloudera.org/job?job_id=aserbin.1565930436.112333

  after 0 out of 1K failed:
    http://dist-test.cloudera.org/job?job_id=aserbin.1565931149.115149

Change-Id: If0b62027a1a4db18bfaa6c89b3070c918fc4f88a
---
M src/kudu/util/sanitizer_options.cc
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/13763/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13763
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0b62027a1a4db18bfaa6c89b3070c918fc4f88a
Gerrit-Change-Number: 13763
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)