You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2023/11/17 03:37:34 UTC

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20712


Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................

IMPALA-12567: Deflake test_75_percent_availability

TestExecutorGroups.test_75_percent_availability can fail in certains
build/test setup for not starting the last impalad within 5s delay
injection. This patch simplifies the test by launching fewer impalad in
totals (reduced from 8 to 5, excluding coordinator) and increases the
delay injection to ensure test query run at all five executors. The test
renamed to test_partial_availability accordingly.

Testing:
- Run and pass the test against HDFS and S3.

Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 11 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/20712/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20712/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/20712/1/tests/custom_cluster/test_executor_groups.py@1423
PS1, Line 1423: 8
Should you update this number?


http://gerrit.cloudera.org:8080/#/c/20712/1/tests/custom_cluster/test_executor_groups.py@1436
PS1, Line 1436: 8 admission slots and 6 executors
update comment accordingly



-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 03:42:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 19:06:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................

IMPALA-12567: Deflake test_75_percent_availability

TestExecutorGroups.test_75_percent_availability can fail in certains
build/test setup for not starting the last impalad within 5s delay
injection. This patch simplifies the test by launching fewer impalad in
totals (reduced from 8 to 5, excluding coordinator) and increases the
delay injection to ensure test query run at all five executors. The test
renamed to test_partial_availability accordingly.

Testing:
- Run and pass the test against HDFS and S3.

Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Reviewed-on: http://gerrit.cloudera.org:8080/20712
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 17 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9937/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:36:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20712

to look at the new patch set (#3).

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................

IMPALA-12567: Deflake test_75_percent_availability

TestExecutorGroups.test_75_percent_availability can fail in certains
build/test setup for not starting the last impalad within 5s delay
injection. This patch simplifies the test by launching fewer impalad in
totals (reduced from 8 to 5, excluding coordinator) and increases the
delay injection to ensure test query run at all five executors. The test
renamed to test_partial_availability accordingly.

Testing:
- Run and pass the test against HDFS and S3.

Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 17 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/20712/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14468/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 04:07:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Borok-Nagy, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20712

to look at the new patch set (#2).

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................

IMPALA-12567: Deflake test_75_percent_availability

TestExecutorGroups.test_75_percent_availability can fail in certains
build/test setup for not starting the last impalad within 5s delay
injection. This patch simplifies the test by launching fewer impalad in
totals (reduced from 8 to 5, excluding coordinator) and increases the
delay injection to ensure test query run at all five executors. The test
renamed to test_partial_availability accordingly.

Testing:
- Run and pass the test against HDFS and S3.

Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
---
M tests/custom_cluster/test_executor_groups.py
1 file changed, 13 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/12/20712/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 3:

(3 comments)

Thank you!

http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1437
PS2, Line 1437: 
> nit: magic constant
Replaced with variable.


http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1443
PS2, Line 1443: ix
> Now it's 10s
Done


http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1449
PS2, Line 1449: 
> nit: magic constant
Replaced with variable.



-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:27:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:36:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14469/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 04:15:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 2:

(2 comments)

Thanks for the correction!

http://gerrit.cloudera.org:8080/#/c/20712/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/20712/1/tests/custom_cluster/test_executor_groups.py@1423
PS1, Line 1423: 8
> Should you update this number?
This one should be OK to stay 8, not part of the test scenario.
The test query will need 4 at most when compiling against 4 backend only.


http://gerrit.cloudera.org:8080/#/c/20712/1/tests/custom_cluster/test_executor_groups.py@1436
PS1, Line 1436: 8 admission slots and 4 executors
> update comment accordingly
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 03:49:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 04:10:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 2:

(3 comments)

Left a few small comments, otherwise the change makes sense to me.

http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:

http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1437
PS2, Line 1437: 4
nit: magic constant


http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1443
PS2, Line 1443: 5s
Now it's 10s


http://gerrit.cloudera.org:8080/#/c/20712/2/tests/custom_cluster/test_executor_groups.py@1449
PS2, Line 1449: 4
nit: magic constant



-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 13:07:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 3: Code-Review+2

Thanks, LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:34:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12567: Deflake test 75 percent availability

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20712 )

Change subject: IMPALA-12567: Deflake test_75_percent_availability
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14472/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e70f1dde10045c32c2bb4f6f78e8a707c9cd97d
Gerrit-Change-Number: 20712
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:52:21 +0000
Gerrit-HasComments: No