You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/27 06:11:39 UTC
[GitHub] [dolphinscheduler] lenboo commented on a change in pull request #6894: [Improvement][Logger]Logger server integrate into worker server
lenboo commented on a change in pull request #6894:
URL: https://github.com/apache/dolphinscheduler/pull/6894#discussion_r775352065
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/LoggerServiceImpl.java
##########
@@ -218,7 +218,7 @@ private String queryLog(TaskInstance taskInstance, int skipLineNum, int limit) {
String host = getHost(taskInstance.getHost());
logger.info("log host : {} , logPath : {} , logServer port : {}", host, taskInstance.getLogPath(),
- PropertyUtils.getInt(Constants.RPC_PORT, 50051));
+ PropertyUtils.getInt(Constants.RPC_PORT, 1234));
Review comment:
magic number can be replaced with constants
##########
File path: dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/LoggerServiceImpl.java
##########
@@ -218,7 +218,7 @@ private String queryLog(TaskInstance taskInstance, int skipLineNum, int limit) {
String host = getHost(taskInstance.getHost());
logger.info("log host : {} , logPath : {} , logServer port : {}", host, taskInstance.getLogPath(),
- PropertyUtils.getInt(Constants.RPC_PORT, 50051));
+ PropertyUtils.getInt(Constants.RPC_PORT, 1234));
Review comment:
Magic number can be replaced with constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org