You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by aw...@apache.org on 2020/03/18 20:41:22 UTC

[kudu] 02/02: linked_list-test-util: quelch warning

This is an automated email from the ASF dual-hosted git repository.

awong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit e7e7899e3aad7f6118eee9309b2a45ee8d11aa1c
Author: Andrew Wong <aw...@cloudera.com>
AuthorDate: Wed Mar 18 12:14:21 2020 -0700

    linked_list-test-util: quelch warning
    
    I saw this when building in release mode:
    
    ../../src/kudu/util/status.h: In member function ‘void kudu::ScopedRowUpdater::RowUpdaterThread()’:
    ../../src/kudu/util/status.h:91:40: warning: ‘next_key’ may be used uninitialized in this function [-Wmaybe-uninitialized]
         const ::kudu::Status& _s = (to_call);                   \
                                            ^
    In file included from ../../src/kudu/integration-tests/linked_list-test.cc:50:0:
    ../../src/kudu/integration-tests/linked_list-test-util.h:288:13: note: ‘next_key’ was declared here
         int64_t next_key;
                 ^
    
    Change-Id: Ic2f6d9a96b76f1e7c587a53037856001bbda9ea7
    Reviewed-on: http://gerrit.cloudera.org:8080/15479
    Tested-by: Kudu Jenkins
    Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
 src/kudu/integration-tests/linked_list-test-util.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/kudu/integration-tests/linked_list-test-util.h b/src/kudu/integration-tests/linked_list-test-util.h
index b92ac2f..6000566 100644
--- a/src/kudu/integration-tests/linked_list-test-util.h
+++ b/src/kudu/integration-tests/linked_list-test-util.h
@@ -285,7 +285,7 @@ class ScopedRowUpdater {
     session->SetTimeoutMillis(60000 /* 60 seconds */);
     CHECK_OK(session->SetFlushMode(client::KuduSession::AUTO_FLUSH_BACKGROUND));
 
-    int64_t next_key;
+    int64_t next_key = 0;
     while (to_update_.BlockingGet(&next_key).ok()) {
       std::unique_ptr<client::KuduUpdate> update(table_->NewUpdate());
       CHECK_OK(update->mutable_row()->SetInt64(kKeyColumnName, next_key));