You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/13 10:57:40 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #3121: Minor: Clean up `array` test
alamb opened a new pull request, #3121:
URL: https://github.com/apache/arrow-datafusion/pull/3121
# Which issue does this PR close?
re: https://github.com/apache/arrow-datafusion/issues/3115
# Rationale for this change
This test uses an older style of comparison because it was waiting on an upstream fix in arrow
# What changes are included in this PR?
Chang the test to Use the same style as the rest of the tests
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3121: Minor: Clean up `array` test
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3121:
URL: https://github.com/apache/arrow-datafusion/pull/3121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3121: Minor: Clean up `array` test
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3121:
URL: https://github.com/apache/arrow-datafusion/pull/3121#issuecomment-1214141330
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3121?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3121](https://codecov.io/gh/apache/arrow-datafusion/pull/3121?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91cf109) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/b1765f77d0e3b8036b41b5e419e0fc73f556a917?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1765f7) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3121 +/- ##
==========================================
- Coverage 85.95% 85.94% -0.02%
==========================================
Files 291 291
Lines 52382 52378 -4
==========================================
- Hits 45025 45016 -9
- Misses 7357 7362 +5
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3121?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/tests/sql/functions.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9mdW5jdGlvbnMucnM=) | `100.00% <100.00%> (ø)` | |
| [datafusion/core/tests/sql/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9tb2QucnM=) | `96.94% <0.00%> (-0.85%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3121/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.77% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3121: Minor: Clean up `array` test
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3121:
URL: https://github.com/apache/arrow-datafusion/pull/3121#issuecomment-1214959481
Benchmark runs are scheduled for baseline = 48f9b7ab57edce2548997e358eb589c5f23e1bad and contender = ff53f8ba019214575ff0cf860e7610ddb5651074. ff53f8ba019214575ff0cf860e7610ddb5651074 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c29cd6e3c85c41aaafe7fe5f8b22e594...6d3f4e3fb5c64080acfa66912db69a51/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7107d15b7cb141dabaf7488da6e6f711...bb230cc9306d466a8c0c9aa4a9df3c46/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c083c99ffbc946809dea742ac23580e2...d311bc4273194f5883b271b10c9f1419/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c3008a03b39943299f141e52b99c1998...30ae8b5889eb434f9e697ac67244da14/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org