DO NOT REPLY [Bug 16372] New: - PVCS createFolders method checking line start is too strict

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16372>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16372

PVCS createFolders method checking line start is too strict

           Summary: PVCS createFolders method checking line start is too
                    strict
           Product: Ant
           Version: 1.5.1
          Platform: PC
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: Optional Tasks
        AssignedTo: ant-dev@jakarta.apache.org
        ReportedBy: dickinson.j@ucles.org.uk


The code to determine whether to create a folder needs to do a case insensitive 
check on the start of the string. Currently the check is:
if (line.startsWith("\"\\") ||
line.startsWith("\"/") ||
line.startsWith(getLineStart())

I have changed it locally to:
if (line.startsWith("\"\\") ||
line.startsWith("\"/") ||
line.startsWith(getLineStart().toUpperCase()) ||
line.startsWith(getLineStart().toLowerCase()))

Below some example output of the pcli command that allowed me to find the bug 
(note the upper and lower case drive letters):
"p:\quartet\archives\java\com\quidnunc\concurrency\ITimer.java-arc
(C:\quartet\java\com\quidnunc\concurrency\ITimer.java)"
"p:\quartet\archives\java\com\quidnunc\concurrency\ITimerListener.java-arc
(C:\quartet\java\com\quidnunc\concurrency\ITimerListener.java)"
"p:\quartet\archives\java\com\quidnunc\concurrency\ProducerConsumerBuffer.java-
arc(C:\quartet\java\com\quidnunc\concurrency\ProducerConsumerBuffer.java)"
"p:\quartet\archives\java\com\quidnunc\concurrency\ReaderWriterLock.java-arc
(C:\quartet\java\com\quidnunc\concurrency\ReaderWriterLock.java)"
"p:\quartet\archives\java\com\quidnunc\database\BasicConnectionFactory.java-arc
(C:\quartet\java\com\quidnunc\database\BasicConnectionFactory.java)"
"p:\quartet\archives\java\com\quidnunc\database\ConnectionFactory.java-arc
(C:\quartet\java\com\quidnunc\database\ConnectionFactory.java)"
"P:\quartet\archives\java\com\quidnunc\database\dbview\BeanPropMap.java-arc
(C:\quartet\java\com\quidnunc\database\dbview\BeanPropMap.java)"
"P:\quartet\archives\java\com\quidnunc\database\dbview\BeanQuery.java-arc
(C:\quartet\java\com\quidnunc\database\dbview\BeanQuery.java)"
"p:\quartet\archives\java\com\quidnunc\database\dbview\DBUtil.java-arc
(C:\quartet\java\com\quidnunc\database\dbview\DBUtil.java)"
"P:\quartet\archives\java\com\quidnunc\database\dbview\DBViewManager.java-arc
(C:\quartet\java\com\quidnunc\database\dbview\DBViewManager.java)"
"P:\quartet\archives\java\com\quidnunc\database\dbview\DBViewParams.java-arc
(C:\quartet\java\com\quidnunc\database\dbview\DBViewParams.java)"

Only the folders starting with P:\ were created while non of the code for 
folders starting with p:\ were created.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>