You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/09/27 12:05:52 UTC

[GitHub] [submarine] kobe860219 commented on pull request #759: [SUBMARINE-1030]. Refactor database service directories and class name

kobe860219 commented on pull request #759:
URL: https://github.com/apache/submarine/pull/759#issuecomment-927807417


   @KUAN-HSUN-LI  @pingsutw  There is a question that do we need to rename the class like `EnvironmentEntity -> Environment` in entity directory ? If yes, there is a problem in submarine-server-api which will export a same name `Environment` . It will cause duplication. Situation like the line33 and line37 below:
   
   ![image](https://user-images.githubusercontent.com/48027290/134904633-8711aa6d-6db8-4789-805d-5e0810ce8238.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org