[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #868: fix: check if stream_routes is disabled

[GitBox <gi...@apache.org>]

tao12345666333 commented on a change in pull request #868:
URL: https://github.com/apache/apisix-ingress-controller/pull/868#discussion_r817281448



##########
File path: test/e2e/ingress/sanity.go
##########
@@ -186,3 +186,49 @@ var _ = ginkgo.Describe("leader election", func() {
 		}
 	})
 })
+
+var _ = ginkgo.Describe("stream_routes disabled", func() {
+	opts := &scaffold.Options{
+		Name:                  "default",
+		Kubeconfig:            scaffold.GetKubeconfig(),
+		APISIXConfigPath:      "testdata/apisix-stream-disabled.yaml",
+		IngressAPISIXReplicas: 1,
+		HTTPBinServicePort:    80,
+		APISIXRouteVersion:    "apisix.apache.org/v2beta3",
+	}
+	s := scaffold.NewScaffold(opts)
+	ginkgo.It("/ip should return your ip", func() {

Review comment:
       @tokers please see #856  
   Previously, if this stream_route was disabled, it did not work properly




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org