You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2016/06/18 14:23:05 UTC

[jira] [Created] (CRYPTO-85) CryptoCipher ENCRYPT_MODE and DECRYPT_MODE are unnecessary and confusing

Sebb created CRYPTO-85:
--------------------------

             Summary: CryptoCipher ENCRYPT_MODE and DECRYPT_MODE are unnecessary and confusing
                 Key: CRYPTO-85
                 URL: https://issues.apache.org/jira/browse/CRYPTO-85
             Project: Commons Crypto
          Issue Type: Bug
            Reporter: Sebb


The CryptoCipher.ENCRYPT_MODE and DECRYPT_MODE constants don't seem to serve any purpose.

They should be dropped and the javax.crypto.Cipher constants used instead.

Alternatively, replace them with an enum, which would allow the compiler to check the values.

Note: the values currently have to be checked by both JceCipher and OpensslCipher. Since JceCipher uses the Cipher constant that check would disappear if the CryptoCipher constant were dropped.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)