You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Diana Arroyo <da...@us.ibm.com> on 2016/02/25 09:00:32 UTC
Review Request 43995: CMake: Creating MACROS to get time and date.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43995/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Bugs: MESOS-4773
https://issues.apache.org/jira/browse/MESOS-4773
Repository: mesos
Description
-------
CMake: Creating MACROS to get time and date.
Diffs
-----
cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
Diff: https://reviews.apache.org/r/43995/diff/
Testing
-------
Tested on Ubuntu.
Thanks,
Diana Arroyo
Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS
to get time and date.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43995/#review120898
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43995]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 26, 2016, 3:16 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43995/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 3:16 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-4773
> https://issues.apache.org/jira/browse/MESOS-4773
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: CompilationConfigure-Creating MACROS to get time and date.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
>
> Diff: https://reviews.apache.org/r/43995/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS
to get time and date.
Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43995/
-----------------------------------------------------------
(Updated Feb. 26, 2016, 3:16 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Removed unnecessary dependency.
Bugs: MESOS-4773
https://issues.apache.org/jira/browse/MESOS-4773
Repository: mesos
Description
-------
CMake: CompilationConfigure-Creating MACROS to get time and date.
Diffs
-----
cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
Diff: https://reviews.apache.org/r/43995/diff/
Testing
-------
Tested on Ubuntu.
Thanks,
Diana Arroyo
Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS
to get time and date.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43995/#review120727
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43995]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 25, 2016, 6:04 p.m., Diana Arroyo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43995/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2016, 6:04 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-4773
> https://issues.apache.org/jira/browse/MESOS-4773
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: CompilationConfigure-Creating MACROS to get time and date.
>
>
> Diffs
> -----
>
> cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
>
> Diff: https://reviews.apache.org/r/43995/diff/
>
>
> Testing
> -------
>
> Tested on Ubuntu.
>
>
> Thanks,
>
> Diana Arroyo
>
>
Re: Review Request 43995: CMake: CompilationConfigure-Creating MACROS
to get time and date.
Posted by Diana Arroyo <da...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43995/
-----------------------------------------------------------
(Updated Feb. 25, 2016, 6:04 p.m.)
Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu.
Changes
-------
Added escaped quotes to return value in macros.
Summary (updated)
-----------------
CMake: CompilationConfigure-Creating MACROS to get time and date.
Bugs: MESOS-4773
https://issues.apache.org/jira/browse/MESOS-4773
Repository: mesos
Description (updated)
-------
CMake: CompilationConfigure-Creating MACROS to get time and date.
Diffs (updated)
-----
cmake/CompilationConfigure.cmake ab503b23f054ebc9a3877a3eca27b1b4190aa51b
Diff: https://reviews.apache.org/r/43995/diff/
Testing
-------
Tested on Ubuntu.
Thanks,
Diana Arroyo