You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2015/02/25 11:52:41 UTC

Review Request 31412: RANGER-244 - Provide support to Show/Hide Users

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31412/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Bugs: RANGER-244
    https://issues.apache.org/jira/browse/RANGER-244


Repository: ranger


Description
-------

Provide functionality where Users/Groups can he "hidden". Hidden users/groups will not be listed in the autocomplete popup during policy creation.


Diffs
-----

  security-admin/db/mysql/patches/010-users-and-groups-visibility.sql PRE-CREATION 
  security-admin/db/oracle/patches/010-users-and-groups-visibility.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java fa03f2f 
  security-admin/src/main/java/org/apache/ranger/common/RangerCommonEnums.java 33edc28 
  security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 4224cc4 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java af339d2 
  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9ebdd63 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 6a45555 
  security-admin/src/main/java/org/apache/ranger/service/XGroupServiceBase.java c3eebc0 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 5e4875f 
  security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java b8a4487 
  security-admin/src/main/java/org/apache/ranger/view/VXGroup.java 5536b3c 
  security-admin/src/main/java/org/apache/ranger/view/VXUser.java a237377 
  security-admin/src/main/webapp/scripts/collection_bases/VXGroupListBase.js 7329c79 
  security-admin/src/main/webapp/scripts/collection_bases/VXUserListBase.js 5ebcb3c 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 6320028 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js 1a28c11 
  security-admin/src/main/webapp/scripts/views/common/FormInputItemList.js fdc6ec2 
  security-admin/src/main/webapp/scripts/views/common/UserPermissionList.js b4f93cb 
  security-admin/src/main/webapp/scripts/views/common/XATableLayout.js 35f4b4e 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 7cf66a9 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js ee96226 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js e1f8e70 
  security-admin/src/main/webapp/templates/users/UserTableLayout_tmpl.html 421ef53 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java b05ebb4 

Diff: https://reviews.apache.org/r/31412/diff/


Testing
-------

Tested on RHEL6 node with patch.
 1] Create user
 2] The user is available on the listing page
 3] Hide the user and Save
 4] The hidden user is not seen on the User listing page
 5] Try to create a policy for that user ( not possible since the user will not come up in autocomplete )
 6] Unhide the user and try creating policy again. It will allow to create.
 7] Followed the same steps for Groups.


Thanks,

Gautam Borad


Re: Review Request 31412: RANGER-244 - Provide support to Show/Hide Users

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31412/
-----------------------------------------------------------

(Updated March 4, 2015, 2:04 p.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Implemented Vel suggestions for UI.
Added new sql files in this patch.
Made author change in this patch.


Bugs: RANGER-244
    https://issues.apache.org/jira/browse/RANGER-244


Repository: ranger


Description
-------

Provide functionality where Users/Groups can he "hidden". Hidden users/groups will not be listed in the autocomplete popup during policy creation.


Diffs (updated)
-----

  security-admin/db/mysql/patches/010-users-and-groups-visibility.sql PRE-CREATION 
  security-admin/db/oracle/patches/010-users-and-groups-visibility.sql PRE-CREATION 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java fa03f2f 
  security-admin/src/main/java/org/apache/ranger/common/RangerCommonEnums.java 33edc28 
  security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 4224cc4 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java af339d2 
  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9ebdd63 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 6a45555 
  security-admin/src/main/java/org/apache/ranger/service/XGroupServiceBase.java c3eebc0 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 5e4875f 
  security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java b8a4487 
  security-admin/src/main/java/org/apache/ranger/view/VXGroup.java 5536b3c 
  security-admin/src/main/java/org/apache/ranger/view/VXUser.java a237377 
  security-admin/src/main/webapp/scripts/collection_bases/VXGroupListBase.js 7329c79 
  security-admin/src/main/webapp/scripts/collection_bases/VXUserListBase.js 5ebcb3c 
  security-admin/src/main/webapp/scripts/models/VXGroup.js 1a97741 
  security-admin/src/main/webapp/scripts/models/VXUser.js 9961032 
  security-admin/src/main/webapp/scripts/modules/XAOverrides.js df728a3 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 6320028 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js 1a28c11 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 2f3b3d7 
  security-admin/src/main/webapp/scripts/views/common/FormInputItemList.js fdc6ec2 
  security-admin/src/main/webapp/scripts/views/common/UserPermissionList.js b4f93cb 
  security-admin/src/main/webapp/scripts/views/common/XATableLayout.js 35f4b4e 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js fc57134 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 988f57c 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js e1f8e70 
  security-admin/src/main/webapp/styles/xa.css 57ce781 
  security-admin/src/main/webapp/templates/users/UserTableLayout_tmpl.html 421ef53 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java b05ebb4 

Diff: https://reviews.apache.org/r/31412/diff/


Testing
-------

Tested on RHEL6 node with patch.
 1] Create user
 2] The user is available on the listing page
 3] Hide the user and Save
 4] The hidden user is not seen on the User listing page
 5] Try to create a policy for that user ( not possible since the user will not come up in autocomplete )
 6] Unhide the user and try creating policy again. It will allow to create.
 7] Followed the same steps for Groups.


Thanks,

Gautam Borad


Re: Review Request 31412: RANGER-244 - Provide support to Show/Hide Users

Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31412/
-----------------------------------------------------------

(Updated March 4, 2015, 1:38 p.m.)


Review request for ranger, Don Bosco Durai, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.


Changes
-------

Implemented Vel suggestions for UI


Bugs: RANGER-244
    https://issues.apache.org/jira/browse/RANGER-244


Repository: ranger


Description
-------

Provide functionality where Users/Groups can he "hidden". Hidden users/groups will not be listed in the autocomplete popup during policy creation.


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java fa03f2f 
  security-admin/src/main/java/org/apache/ranger/common/RangerCommonEnums.java 33edc28 
  security-admin/src/main/java/org/apache/ranger/entity/XXGroup.java 4224cc4 
  security-admin/src/main/java/org/apache/ranger/entity/XXUser.java af339d2 
  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9ebdd63 
  security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 6a45555 
  security-admin/src/main/java/org/apache/ranger/service/XGroupServiceBase.java c3eebc0 
  security-admin/src/main/java/org/apache/ranger/service/XUserService.java 5e4875f 
  security-admin/src/main/java/org/apache/ranger/service/XUserServiceBase.java b8a4487 
  security-admin/src/main/java/org/apache/ranger/view/VXGroup.java 5536b3c 
  security-admin/src/main/java/org/apache/ranger/view/VXUser.java a237377 
  security-admin/src/main/webapp/scripts/collection_bases/VXGroupListBase.js 7329c79 
  security-admin/src/main/webapp/scripts/collection_bases/VXUserListBase.js 5ebcb3c 
  security-admin/src/main/webapp/scripts/models/VXGroup.js 1a97741 
  security-admin/src/main/webapp/scripts/models/VXUser.js 9961032 
  security-admin/src/main/webapp/scripts/modules/XAOverrides.js df728a3 
  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 6320028 
  security-admin/src/main/webapp/scripts/utils/XAEnums.js 1a28c11 
  security-admin/src/main/webapp/scripts/utils/XAUtils.js 2f3b3d7 
  security-admin/src/main/webapp/scripts/views/common/FormInputItemList.js fdc6ec2 
  security-admin/src/main/webapp/scripts/views/common/UserPermissionList.js b4f93cb 
  security-admin/src/main/webapp/scripts/views/common/XATableLayout.js 35f4b4e 
  security-admin/src/main/webapp/scripts/views/policies/PermissionList.js fc57134 
  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 988f57c 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js e1f8e70 
  security-admin/src/main/webapp/styles/xa.css 57ce781 
  security-admin/src/main/webapp/templates/users/UserTableLayout_tmpl.html 421ef53 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java b05ebb4 

Diff: https://reviews.apache.org/r/31412/diff/


Testing
-------

Tested on RHEL6 node with patch.
 1] Create user
 2] The user is available on the listing page
 3] Hide the user and Save
 4] The hidden user is not seen on the User listing page
 5] Try to create a policy for that user ( not possible since the user will not come up in autocomplete )
 6] Unhide the user and try creating policy again. It will allow to create.
 7] Followed the same steps for Groups.


Thanks,

Gautam Borad