[GitHub] [jackrabbit-oak] thomasmueller commented on a change in pull request #339: OAK-9529 | Log message 'Another copy of the index update is already r…

[GitBox <gi...@apache.org>]

thomasmueller commented on a change in pull request #339:
URL: https://github.com/apache/jackrabbit-oak/pull/339#discussion_r687437380



##########
File path: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/AsyncIndexUpdate.java
##########
@@ -501,9 +501,9 @@ private void runWhenPermitted() {
             long currentTime = System.currentTimeMillis();
             if (leaseEndTime > currentTime) {
                 long leaseExpMsg = (leaseEndTime - currentTime) / 1000;
-                String err = String.format("Another copy of the index update is already running; skipping this update. " +
+                String msg = String.format("Another copy of the index update is already running; skipping this update. " +
                         "Time left for lease to expire %d s. Indexing can resume by %tT", leaseExpMsg, leaseEndTime);
-                indexStats.failed(new Exception(err, newConcurrentUpdateException()));

Review comment:
       Are you sure this doesn't have a side effect? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org