[GitHub] [accumulo] EdColeman commented on pull request #1649: Addresses four compaction service follow on issues.

[GitBox <gi...@apache.org>]

EdColeman commented on pull request #1649:
URL: https://github.com/apache/accumulo/pull/1649#issuecomment-669311242


   Looking at the metrics generated by CompactionExecutorsMetrics.  
   
   My initial concern was that there could be cardinality issues if the metrics names are unbounded - that does not seem to be an issue.  Using the current code in your branch, I quickly added a delay in the FateConcurrencyIT test that forces a pause while a compaction FATE transaction is running so that the metrics system has time to write records to the test output file.  The generated record for the IT test tserver looks like:
   
   `1596645249079 tserver.compactionExecutors: Context=tserver, ProcessName=TabletServer, Hostname=ip-xxx-xxx-xxx-xxx, default_large_queued=0, default_large_running=0, default_medium_queued=0, default_medium_running=0, default_small_queued=0, default_small_running=0, meta_huge_queued=0, meta_huge_running=0, meta_small_queued=0, meta_small_running=0, root_small_queued=0, root_small_running=0, root_huge_queued=0, root_huge_running=0, default_any_queued=0, default_any_running=1`
   
   This looks good, but why is default_any_running=1 but nothing in default large, medium or small?  Is default_any a separate queue, or should it be the sum of all default_any_ ?
   
   With this forced test, I know the FATE transaction is "IN_PROGRESS"  - it uses a slow compaction runner that pauses 250ms in the iterator before each next() call - could that be changing the "running" to something where the thread is paused and that does not count as "running" 
   
   Before digging I just want to validate that my assumptions w.r.t the names is accurate.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org