[GitHub] [hudi] bschell commented on pull request #7759: [HUDI-5624] Fix HoodieAvroRecordMerger to use new precombine API

["bschell (via GitHub)" <gi...@apache.org>]

bschell commented on PR #7759:
URL: https://github.com/apache/hudi/pull/7759#issuecomment-1407069668

   @alexeykudinkin I added an end-to-end test for PartialUpdateAvroPayload that catches this regression. While doing so I found and fixed another bug in HoodieAvroRecordMerger here: https://github.com/apache/hudi/blob/master/hudi-common/src/main/java/org/apache/hudi/common/model/HoodieAvroRecordMerger.java#L76
   
   Basically HoodieMetadataPayload is not the only payload class that returns an entirely new payload. This breaks any of the "merge" payloads. I was thinking it might be even better to add this check as an API to HoodieRecordPayload so that we do not have to hardcode all the exceptions here but I kept the smaller change for now as we are deprecating this path later anyway.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org