You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mikebridge (via GitHub)" <gi...@apache.org> on 2026/08/21 18:22:41 UTC
[PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
mikebridge opened a new pull request, #43401:
URL: https://github.com/apache/superset/pull/43401
### SUMMARY
With soft delete enabled, the archive confirmation told users their chart, dashboard, or dataset "will be moved to Recently Archived" without saying where that is. QA (SC-117152, TC-099/TC-101) compared the modal against the design of record and found the recovery-location hint missing — the one genuine usability gap among the diffs: a user reading only the modal had no way to know recovery lives under **Settings → Manage → Recently Archived**.
The confirmation body now names the location in all four variants (singular/plural, with and without a configured retention window):
> This chart will be moved to Recently Archived **in the Settings menu**. You can recover it there within 30 days.
Each variant remains a single, complete translation unit; only the noun and day count are interpolated. The four corresponding `messages.pot` msgids are updated in step.
**Terminology decision (recorded on the ticket):** "Archive / Recently Archived" is confirmed as the copy of record — it was chosen deliberately during the soft-delete rollout to keep recoverable deletion distinct from the "Delete permanently" purge action offered on the recovery page. The design node's "Delete / Recently Deleted" wording is the stale side and is being updated separately by design; that work does not block this change.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Copy-only change; QA's before screenshots are attached to [SC-117152]. Before/after body text:
| | Body |
|---|---|
| Before | This chart will be moved to Recently Archived. You can recover it there within 30 days. |
| After | This chart will be moved to Recently Archived **in the Settings menu**. You can recover it there within 30 days. |
### TESTING INSTRUCTIONS
1. Enable `SOFT_DELETE`.
2. Trigger delete on a chart, dashboard, or dataset (single and bulk).
3. The confirmation body names the recovery location; title and button still read "Archive".
4. `npm run test -- src/utils/softDeleteCopy.test.ts` — 9 tests, expectations updated to the new copy.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
- [ ] Has associated issue:
- [x] Required feature flags: `SOFT_DELETE` (copy renders only with the flag on; flag-off copy unchanged)
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
This PR was developed with AI assistance (Claude Code); a human (@mikebridge) reviews before undrafting.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5376132142
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 1dbf497a59c29ea76e66915cb77fe045cd78d5a6 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a88d3561eecab00083fdf0d |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43401--superset-docs-preview.netlify.app](https://deploy-preview-43401--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcoxDoAgDADAv3S2CWhA4g98BrYlDmAJshjj32W74V6oTUvtsAFMcLR40Tl8E1q7WjfjrakjS5YuWJRjRtL6jMtSsz47j-1jCLw4b0UoHsaYsCROhuH7AQ) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-43401--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5377169956
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5373869557
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43401?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 66.02%. Comparing base ([`fd7095d`](https://app.codecov.io/gh/apache/superset/commit/fd7095df9a55da41818be01f725edfbd491c1ab7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1a7fa36`](https://app.codecov.io/gh/apache/superset/commit/1a7fa3682ec638660ea36f35b6abe17a41a0fa78?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #43401 +/- ##
==========================================
- Coverage 66.71% 66.02% -0.69%
==========================================
Files 2876 2876
Lines 164243 164243
Branches 37921 37921
==========================================
- Hits 109570 108437 -1133
- Misses 52485 53625 +1140
+ Partials 2188 2181 -7
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.09% <ø> (ø)` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.03% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.65% <ø> (-1.41%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.51% <ø> (?)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/43401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43401?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #43401:
URL: https://github.com/apache/superset/pull/43401#discussion_r3833745532
##########
superset-frontend/src/utils/softDeleteCopy.ts:
##########
@@ -66,21 +66,21 @@ export function archiveConfirmDescription(
if (days) {
return plural
? t(
- 'These %(type)s will be moved to Recently Archived. You can recover them there within %(days)s days.',
+ 'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)s days.',
{ type: typeLabel, days },
Review Comment:
**Suggestion:** The retention setting accepts a valid one-day window, but this message always uses the plural unit “days”, producing “within 1 days.” Use singular/plural-aware translation variants so the confirmation remains grammatically correct for a one-day retention period. [logic error]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Archive confirmations display incorrect singular grammar.
- ⚠️ Affects one-day chart, dashboard, and dataset retention windows.
```
</details>
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/utils/softDeleteCopy.ts
**Line:** 69:70
**Comment:**
*Logic Error: The retention setting accepts a valid one-day window, but this message always uses the plural unit “days”, producing “within 1 days.” Use singular/plural-aware translation variants so the confirmation remains grammatically correct for a one-day retention period.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43401&comment_hash=1e019216859881acf11e1530766ce5d2c5d81e25abed426fd52a9dbf38a2862c&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F43401&comment_hash=1e019216859881acf11e1530766ce5d2c5d81e25abed426fd52a9dbf38a2862c&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5373675754
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5375602817
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi merged PR #43401:
URL: https://github.com/apache/superset/pull/43401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5399762735
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on code in PR #43401:
URL: https://github.com/apache/superset/pull/43401#discussion_r3847845025
##########
superset-frontend/src/utils/softDeleteCopy.ts:
##########
@@ -66,21 +66,21 @@ export function archiveConfirmDescription(
if (days) {
return plural
? t(
- 'These %(type)s will be moved to Recently Archived. You can recover them there within %(days)s days.',
+ 'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)s days.',
{ type: typeLabel, days },
Review Comment:
Already addressed — this was fixed in `1dbf497a59`, before this thread was reviewed.
Both timed variants now use `tn()` and pluralize on the day count, so a one-day retention window reads "within 1 day":
```ts
return plural
? tn(
'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)s day.',
'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)s days.',
days,
{ type: typeLabel, days },
)
: tn(/* singular-subject forms */);
```
The test suite pins it with a `days = 1` expectation for both the single and bulk paths, and @richardfogaca raised the same point independently and approved after the fix landed.
Resolving.
_(Comment by Claude (AI), on behalf of @mikebridge.)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5375456694
<!-- Bito Reply -->
The flagged issue is correct. The current implementation uses a hardcoded "days" string, which results in grammatically incorrect output when the retention period is one day. To resolve this, you should use the `nplurals` support provided by the `t()` translation function (often via `tn()`) to handle singular and plural forms correctly.
Would you like me to fetch all other comments on this PR to validate and implement fixes for them as well?
**superset-frontend/src/utils/softDeleteCopy.ts**
```
return plural
? tn(
'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)d day.',
'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)d days.',
days,
{ type: typeLabel, days },
)
: tn(
'This %(type)s will be moved to Recently Archived in the Settings menu. You can recover it there within %(days)d day.',
'This %(type)s will be moved to Recently Archived in the Settings menu. You can recover it there within %(days)d days.',
days,
{ type: typeLabel, days },
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on code in PR #43401:
URL: https://github.com/apache/superset/pull/43401#discussion_r3834154431
##########
superset-frontend/src/utils/softDeleteCopy.ts:
##########
@@ -66,21 +66,21 @@ export function archiveConfirmDescription(
if (days) {
return plural
? t(
- 'These %(type)s will be moved to Recently Archived. You can recover them there within %(days)s days.',
+ 'These %(type)s will be moved to Recently Archived in the Settings menu. You can recover them there within %(days)s days.',
{ type: typeLabel, days },
Review Comment:
Fixed in 1dbf497a59: the timed variants now pluralize on the day count with `tn()` (each case remains one complete translation unit for translators), `messages.pot` carries the matching `msgid`/`msgid_plural` pairs (validated with `msgfmt --check-format`), and the copy tests pin the one-day singular for both the single and bulk variants.
*Comment by Claude (AI) on behalf of @mikebridge.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(soft-delete): name the recovery location in the archive confirmation [superset]
Posted by "mikebridge (via GitHub)" <gi...@apache.org>.
mikebridge commented on PR #43401:
URL: https://github.com/apache/superset/pull/43401#issuecomment-5376122178
@richardfogaca Done in 1dbf497a59 — both timed variants switched to `tn()` on the day count, with the `days = 1` singular expectation added for the single and bulk forms (`softDeleteCopy.test.ts`, 10/10 passing). The `.pot` now carries the corresponding `msgid`/`msgid_plural` pairs.
*Comment by Claude (AI) on behalf of @mikebridge.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org