[GitHub] [nuttx] anchao commented on a diff in pull request #9897: cmake: add support to compile definitions for apps

["anchao (via GitHub)" <gi...@apache.org>]

anchao commented on code in PR #9897:
URL: https://github.com/apache/nuttx/pull/9897#discussion_r1274285136


##########
cmake/nuttx_add_application.cmake:
##########
@@ -35,13 +35,14 @@ define_property(
 #
 # Usage: nuttx_add_application( NAME <string> [ PRIORITY <string> ] [ STACKSIZE
 # <string> ] [ COMPILE_FLAGS <list> ] [ INCLUDE_DIRECTORIES <list> ] [ DEPENDS
-# <string> ] [ MODULE <string> ] [ SRCS <list> ] )

Review Comment:
   It seems that the style of the comment is wrongly formatted in the check of cmake-format. could we consider using the comment fence to protect this part of the code?
   
   https://github.com/cheshirekow/cmake_format/blob/master/cmakelang/doc/README.rst?plain=1#L239-L250



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org