You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 16:09:51 UTC

[GitHub] [superset] maloun96 commented on a change in pull request #12391: chore: Show datasets when search input is empty

maloun96 commented on a change in pull request #12391:
URL: https://github.com/apache/superset/pull/12391#discussion_r555162882



##########
File path: superset-frontend/src/datasource/ChangeDatasourceModal.tsx
##########
@@ -224,6 +221,7 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
       onHide={onHide}
       responsive
       title={t('Change Dataset')}
+      height="350px"

Review comment:
       isn't better to send height without 'px'?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org