[GitHub] [druid] LakshSingla commented on a change in pull request #11978: Fix classNotFoundException when connecting to secure LDAP

[GitBox <gi...@apache.org>]

LakshSingla commented on a change in pull request #11978:
URL: https://github.com/apache/druid/pull/11978#discussion_r754966083



##########
File path: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
##########
@@ -235,6 +245,7 @@ boolean validatePassword(BasicAuthLDAPConfig ldapConfig, LdapName userDn, char[]
         LOG.warn("Exception closing LDAP context");
         // ignored
       }
+      Thread.currentThread().setContextClassLoader(currentClassLoader);

Review comment:
       Should the classLoader be reset in a `finally` block? 
   ```suggestion
     finally {
         Thread.currentThread().setContextClassLoader(currentClassLoader);
     }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org