[GitHub] szha closed pull request #11379: support shared parameter in summary

[GitBox <gi...@apache.org>]

szha closed pull request #11379: support shared parameter in summary
URL: https://github.com/apache/incubator-mxnet/pull/11379
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/python/mxnet/gluon/block.py b/python/mxnet/gluon/block.py
index 0ef28496c20..731d5414973 100644
--- a/python/mxnet/gluon/block.py
+++ b/python/mxnet/gluon/block.py
@@ -563,6 +563,7 @@ def summary(self, *inputs):
             :class:`mxnet.ndarray.NDArray` is supported.
         """
         summary = OrderedDict()
+        seen = set()
         hooks = []
 
         def _get_shape_str(args):
@@ -611,9 +612,14 @@ def _summary_hook(block, _, outputs):
 
                 params = 0
                 summary[m_key]['trainable'] = 0
+                summary[m_key]['shared'] = 0
                 for p in block._reg_params.values():
                     params += p.data().size
                     summary[m_key]['trainable'] += 0 if p.grad_req == 'null' else p.data().size
+                    if p in seen:
+                        summary[m_key]['shared'] += p.data().size
+                    else:
+                        seen.add(p)
                 summary[m_key]['n_params'] = params
 
             from .nn.basic_layers import Sequential, HybridSequential
@@ -624,6 +630,7 @@ def _summary_hook(block, _, outputs):
         summary['Input']['output_shape'] = _get_shape_str(inputs)
         summary['Input']['n_params'] = 0
         summary['Input']['trainable'] = 0
+        summary['Input']['shared'] = 0
 
         try:
             self.apply(_register_summary_hook)
@@ -635,16 +642,19 @@ def _summary_hook(block, _, outputs):
             print('='*80)
             total_params = 0
             trainable_params = 0
+            shared_params = 0
             for layer in summary:
                 print(line_format.format(layer,
                                          str(summary[layer]['output_shape']),
                                          summary[layer]['n_params']))
                 total_params += summary[layer]['n_params']
                 trainable_params += summary[layer]['trainable']
+                shared_params += summary[layer]['shared']
             print('='*80)
             print('Total params: ' + str(total_params))
             print('Trainable params: ' + str(trainable_params))
             print('Non-trainable params: ' + str(total_params - trainable_params))
+            print('Shared params: ' + str(shared_params))
             print('-'*80)
         finally:
             for h in hooks:
diff --git a/tests/python/unittest/test_gluon.py b/tests/python/unittest/test_gluon.py
index 7fff6b8c1f5..d275cd61029 100644
--- a/tests/python/unittest/test_gluon.py
+++ b/tests/python/unittest/test_gluon.py
@@ -1264,9 +1264,9 @@ def test_summary():
 
     net2 = nn.Sequential()
     with net2.name_scope():
-        net2.add(nn.Embedding(10, 20))
+        net2.add(nn.Embedding(40, 30))
         net2.add(gluon.rnn.LSTM(30))
-        net2.add(nn.Dense(40, flatten=False))
+        net2.add(nn.Dense(40, flatten=False, params=net2[0].params))
     net2.initialize()
     net2.summary(mx.nd.ones((80, 32)))
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services