You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/07/31 13:22:54 UTC

[GitHub] [skywalking-terraform] kezhenxu94 opened a new pull request, #14: Some improvements for Terraform scripts

kezhenxu94 opened a new pull request, #14:
URL: https://github.com/apache/skywalking-terraform/pull/14

   - Add egress security group for the instances so that they can access the internet, this is required to install packages (Java) and download SkyWalking package.
   - Remove the `ping` playbook, it's incomplete for now, and can be simply replaced by `ansible -m ping all` in command line.
   - Create an SSH key pair on AWS and save to local file, so that users don't have to create the key pair beforehand.
   - Find an AMI by specific filters to avoid hardcode the AMI ID, the hardcoded AMI might be not available in other regions, for example, the current hardcoded `ami-026ebd4cfe2c043b2` is not available in ap-southeast-1 region.
   - Add doc for Ansible playbook.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-terraform] kezhenxu94 merged pull request #14: Some improvements for Terraform scripts

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 merged PR #14:
URL: https://github.com/apache/skywalking-terraform/pull/14


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-terraform] rabajaj0509 commented on pull request #14: Some improvements for Terraform scripts

Posted by "rabajaj0509 (via GitHub)" <gi...@apache.org>.
rabajaj0509 commented on PR #14:
URL: https://github.com/apache/skywalking-terraform/pull/14#issuecomment-1661524984

   During my testing, everything worked flawlessly, but I noticed that the files being created have all permissions set (755). For example, ~/.ssh/skywalking.pem and other files in the inventory are being created with these permissions. To improve security and restrict access appropriately, it might be a good idea to set the permissions to 644 instead.
   
   Once the fix is in place and the files are created with the appropriate permissions (644), please go ahead and merge this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking-terraform] kezhenxu94 commented on pull request #14: Some improvements for Terraform scripts

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #14:
URL: https://github.com/apache/skywalking-terraform/pull/14#issuecomment-1658366506

   Hey, @rabajaj0509 mind taking a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org