You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "jon-wei (via GitHub)" <gi...@apache.org> on 2023/03/17 19:49:04 UTC
[GitHub] [druid] jon-wei opened a new pull request, #13946: Update DruidSchemaManager methods to provide SegmentMetadataCache
jon-wei opened a new pull request, #13946:
URL: https://github.com/apache/druid/pull/13946
This PR updates the methods on the `DruidSchemaManager` interface to provide the segment metadata cache to the extension implementation, for use cases where the extension also needs to consider what metadata is present in the Druid segments.
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update DruidSchemaManager methods to provide SegmentMetadataCache (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13946:
URL: https://github.com/apache/druid/pull/13946#issuecomment-1984824601
This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei commented on pull request #13946: Update DruidSchemaManager methods to provide SegmentMetadataCache
Posted by "jon-wei (via GitHub)" <gi...@apache.org>.
jon-wei commented on PR #13946:
URL: https://github.com/apache/druid/pull/13946#issuecomment-1476709040
@kfaraz I tried that initially, but the `SegmentMetadataCache` is not injectable on non-broker nodes and causes them to fail startup, and I don't think we have a way of selectively binding a `DruidSchemaManager` implementation only for broker nodes in extension modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] kfaraz commented on pull request #13946: Update DruidSchemaManager methods to provide SegmentMetadataCache
Posted by "kfaraz (via GitHub)" <gi...@apache.org>.
kfaraz commented on PR #13946:
URL: https://github.com/apache/druid/pull/13946#issuecomment-1536012966
@jon-wei , sorry I forgot to reply to your comment. Do you think declaring a field for segmentMetadataCache annotated with `@Inject(optional = true)` in your impl of `DruidSchemaManager` would work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update DruidSchemaManager methods to provide SegmentMetadataCache (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13946:
URL: https://github.com/apache/druid/pull/13946#issuecomment-1935131177
This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] github-code-scanning[bot] commented on a diff in pull request #13946: Update DruidSchemaManager methods to provide SegmentMetadataCache
Posted by "github-code-scanning[bot] (via GitHub)" <gi...@apache.org>.
github-code-scanning[bot] commented on code in PR #13946:
URL: https://github.com/apache/druid/pull/13946#discussion_r1140682021
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchemaManager.java:
##########
@@ -51,12 +51,12 @@
@Deprecated
Map<String, DruidTable> getTables();
- default DruidTable getTable(String name)
+ default DruidTable getTable(String name, SegmentMetadataCache segmentMetadataCache)
Review Comment:
## Useless parameter
The parameter 'segmentMetadataCache' is never used.
[Show more details](https://github.com/apache/druid/security/code-scanning/4408)
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchemaManager.java:
##########
@@ -51,12 +51,12 @@
@Deprecated
Map<String, DruidTable> getTables();
- default DruidTable getTable(String name)
+ default DruidTable getTable(String name, SegmentMetadataCache segmentMetadataCache)
{
return getTables().get(name);
}
- default Set<String> getTableNames()
+ default Set<String> getTableNames(SegmentMetadataCache segmentMetadataCache)
Review Comment:
## Useless parameter
The parameter 'segmentMetadataCache' is never used.
[Show more details](https://github.com/apache/druid/security/code-scanning/4407)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Update DruidSchemaManager methods to provide SegmentMetadataCache (druid)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13946: Update DruidSchemaManager methods to provide SegmentMetadataCache
URL: https://github.com/apache/druid/pull/13946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org