[GitHub] [airflow] dstandish commented on a change in pull request #20753: Make delete_pod change more prominent in changelog

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #20753:
URL: https://github.com/apache/airflow/pull/20753#discussion_r780380758



##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -25,17 +25,23 @@ Changelog
 Breaking changes
 ~~~~~~~~~~~~~~~~
 
+* ``Parameter is_delete_operator_pod default is changed to True (#20575)``
 * ``Simplify KubernetesPodOperator (#19572)``
-* ``Delete pods by default in KubernetesPodOperator (#20575)``
 * ``Move pod_mutation_hook call from PodManager to KubernetesPodOperator (#20596)``
 * ``Rename ''PodLauncher'' to ''PodManager'' (#20576)``
 
-.. warning:: Many methods in ``KubernetesPodOperator`` and ``PodLauncher`` have been renamed.
-    If you have subclassed ``KubernetesPodOperator`` will need to update your subclass to reflect
-    the new structure. Additionally ``PodStatus`` enum has been renamed to ``PodPhase``.
+Parameter is_delete_operator_pod has new default
+````````````````````````````````````````````````
+
+Previously, the default for param ``is_delete_operator_pod`` was ``False``, which means that
+after a task runs, its pod is not deleted by the operator and remains on the
+cluster indefinitely.  With this release, we change the default to ``True``.
 
 Notes on changes KubernetesPodOperator and PodLauncher
 ``````````````````````````````````````````````````````

Review comment:
       you mean you want 2 newlines bettween `cluster indef` and `notes on changes`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org