You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@netbeans.apache.org by junichi11 <gi...@git.apache.org> on 2017/10/12 02:45:52 UTC
[GitHub] incubator-netbeans pull request #129: Sort rat excludes alphabetically
GitHub user junichi11 opened a pull request:
https://github.com/apache/incubator-netbeans/pull/129
Sort rat excludes alphabetically
To prevent to add duplicate one, rat excludes should be sorted alphabetically. Actually, there was one duplicate line.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/junichi11/incubator-netbeans sort-rat-excludes-alphabetically
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-netbeans/pull/129.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #129
----
commit 6e0de07d040cb8c582a58025134002081731eef8
Author: Junichi Yamamoto <ju...@apache.org>
Date: 2017-10-12T02:28:14Z
Remove a duplicate rat exclude
commit ad3607a092c54f8266fb57dab4d6df02a7951c18
Author: Junichi Yamamoto <ju...@apache.org>
Date: 2017-10-12T02:32:41Z
Sort rat excludes alpabetically
Prevent to add duplicate one.
----
---
[GitHub] incubator-netbeans issue #129: Sort rat excludes alphabetically
Posted by emilianbold <gi...@git.apache.org>.
Github user emilianbold commented on the issue:
https://github.com/apache/incubator-netbeans/pull/129
I like the idea but this will cause conflicts on all the open PRs that add an exclude. So, I'd rather we do this at the end of the module review. Even if a duplicate sneaks in, it's harmless.
---
[GitHub] incubator-netbeans issue #129: Sort rat excludes alphabetically
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on the issue:
https://github.com/apache/incubator-netbeans/pull/129
> So, I'd rather we do this at the end of the module review.
Yes, We need not hurry to do this at all :)
---
[GitHub] incubator-netbeans pull request #129: Sort rat excludes alphabetically
Posted by junichi11 <gi...@git.apache.org>.
Github user junichi11 commented on a diff in the pull request:
https://github.com/apache/incubator-netbeans/pull/129#discussion_r144185514
--- Diff: nbbuild/build.xml ---
@@ -1985,7 +1985,6 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d
<exclude name="javafx2.project/src/org/netbeans/modules/javafx2/project/templates/**" /> <!--license would be visible when users edit the templates inside their IDE-->
<exclude name="utilities/test/unit/src/org/netbeans/modules/openfile/resources/recent_files/*" /> <!--test data-->
<exclude name="**/*.url" /> <!--no degree of creativity-->
- <exclude name="spi.navigator/test/unit/src/org/netbeans/modules/navigator/resources/lastsel/file.lastsel_mime1" /> <!--empty file-->
--- End diff --
This line starts with TAB. So, I removed this line.
---